Bug 1370188

Summary: (default settings) should use gstreamer 1.0 instead of gstreamer 0.10
Product: [Fedora] Fedora Reporter: wislufle <wislufle>
Component: mail-notificationAssignee: Dmitry Butskoy <dmitry>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 26CC: dmitry, erik-fedora
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: mail-notification-5.4-92.git.9ae8768.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-12 18:25:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description wislufle 2016-08-25 13:30:55 UTC
Description of problem:
mail-notification uses /usr/bin/gst-launch-0.10 (provided by gstreamer 0.10 package) to play the sound (when enabled), however, gstreamer 0.10 package is not listed as a dependency for mail-notification, which can lead to sound not working if gstreamer 0.10 is not installed.

Version-Release number of selected component (if applicable):
5.4-86.git.eab5c1

How reproducible:
100%

Steps to Reproduce:
1. ensure gstreamer 0.10 is not installed
2. enable sound within mail-notification configuration dialog
3. select "Display test message" in config dialog

Actual results:
No sound is played.

Expected results:
Sound file should be played.

Additional info:
the command used to play the sound file is in gconf at /apps/mail-notification/sounds/play-command

the default value is:
exec gst-launch-0.10 filesrc location=%file ! decodebin ! audioconvert ! gconfaudiosink >/dev/null 2>&1

Perhaps this should be edited to use /usr/bin/gst-launch-1.0 (from gstreamer 1.0) instead of gst-launch-0.10 (from gstreamer 0.10)? However, just replacing "gst-launch-0.10" with "gst-launch-1.0" doesn't seem to do the trick. I've worked around this issue by setting the command to the following:
exec paplay '%file' &>/dev/null

Comment 1 Dmitry Butskoy 2016-08-28 23:02:17 UTC
We should avoid the hard dependency on any gstreamer for sound (as well as on any mailer program for mail reading), since it is an additional option, and it is not required for the main mail-notification work (ie. inform user about new mail visually).

Certainly, the default value for /apps/mail-notification/sounds/play-command should be changed, as gstreamer-0.10 is going to be obsoleted. Unfortunately, the upstream of MN is stalled, and it seems that nothing will be changed there.

Could you please try to explain why gst-launch-1.0 does not work? (I would like to try to avoid paplay since it probably might be not installed).

Comment 2 wislufle 2016-08-28 23:42:43 UTC
paplay is provided by pulseaudio-utils, which is installed by default in the Mate spin of Fedora 24 (I can't confirm whether this is default in the other desktop flavors).

regarding replacing "gst-launch-0.10" with "gst-launch-1.0" ... this produces the following command (note that I know nothing about either version of gst-launch or whether they're supposed to be compatible):
exec gst-launch-1.0 filesrc location=%file ! decodebin ! audioconvert ! gconfaudiosink >/dev/null 2>&1

To test from the command line, you have to remove "exec" and ">/dev/null 2>&1", and you have to replace "%file" with a path to a sound file. This produces the following message:
WARNING: erroneous pipeline: no element "gconfaudiosink"

If I remove "! gconfaudiosink", output is:
Setting pipeline to PAUSED ...
Pipeline is PREROLLING ...
Pipeline is PREROLLED ...
Setting pipeline to PLAYING ...
New clock: GstSystemClock
ERROR: from element /GstPipeline:pipeline0/GstDecodeBin:decodebin0/GstOggDemux:oggdemux0: Internal data stream error.
Additional debug info:
gstoggdemux.c(4849): gst_ogg_demux_loop (): /GstPipeline:pipeline0/GstDecodeBin:decodebin0/GstOggDemux:oggdemux0:
stream stopped, reason not-linked
Execution ended after 0:00:00.000220779
Setting pipeline to PAUSED ...
Setting pipeline to READY ...
Setting pipeline to NULL ...
Freeing pipeline ...

Comment 3 Fedora End Of Life 2017-07-25 22:38:47 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 4 wislufle 2017-08-02 00:12:21 UTC
the command used to play the sound file is in gconf at /apps/mail-notification/sounds/play-command

the current value of:
exec gst-launch-0.10 filesrc location=%file ! decodebin ! audioconvert ! gconfaudiosink >/dev/null 2>&1

should be replaced with:
exec gst-launch-1.0 filesrc location=%file ! decodebin ! audioconvert ! autoaudiosink >/dev/null 2>&1

(replace "gst-launch-0.10" with "gst-launch-1.0" and "gconfaudiosink" with "autoaudiosink")

this will cause mail-notification to use gstreamer 1.0 instead of gstreamer 0.10

could you please update the default value for this setting accordingly? thanks in advance :-)

Comment 5 Fedora Update System 2017-08-02 21:16:22 UTC
mail-notification-5.4-92.git.9ae8768.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6c05994fec

Comment 6 Fedora Update System 2017-08-04 00:24:03 UTC
mail-notification-5.4-92.git.9ae8768.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6c05994fec

Comment 7 Fedora Update System 2017-08-12 18:25:07 UTC
mail-notification-5.4-92.git.9ae8768.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.