Bug 1370390

Summary:	Locks xlators is leaking fdctx in pl_release()
Product:	[Community] GlusterFS	Reporter:	Oleksandr Natalenko <oleksandr>
Component:	locks	Assignee:	Oleksandr Natalenko <oleksandr>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	3.8	CC:	anoopcs, bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.8.4	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1371018 (view as bug list)		Environment:
Last Closed:	2016-09-16 18:28:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1369049, 1371018

Description Oleksandr Natalenko 2016-08-26 07:18:10 UTC

Locks xlators is leaking fdctx in pl_release when inode_ctx_get return non-zero.

Comment 1 Worker Ant 2016-08-26 07:19:26 UTC

REVIEW: http://review.gluster.org/15323 (features/locks: fix fdctx leak in locks xlators) posted (#2) for review on release-3.8 by Oleksandr Natalenko (oleksandr)

Comment 2 Worker Ant 2016-08-26 15:02:52 UTC

COMMIT: http://review.gluster.org/15323 committed in release-3.8 by Pranith Kumar Karampuri (pkarampu) 
------
commit 50fa85c071553b41f33a8167b31c8a9b54cfe3e3
Author: yanping.gao <yanping.gao>
Date:   Wed Aug 24 06:47:49 2016 +0000

    features/locks: fix fdctx leak in locks xlators
    
    Problem:
    Locks xlators is leaking fdctx in pl_release when
    inode_ctx_get return non-zero
    
    Fix:
    This patch fixes fdctx leak in pl_release path
    
    > Reviewed-on: http://review.gluster.org/15302
    > Smoke: Gluster Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    > Tested-by: Pranith Kumar Karampuri <pkarampu>
    
    Change-Id: Icd5c5c681b7d890e7971b3b06d4258a51d45097d
    BUG: 1370390
    Signed-off-by: Yanping.gao <yanping.gao>
    Signed-off-by: Oleksandr Natalenko <oleksandr>
    Reviewed-on: http://review.gluster.org/15323
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Niels de Vos 2016-09-12 05:38:13 UTC

All 3.8.x bugs are now reported against version 3.8 (without .x). For more information, see http://www.gluster.org/pipermail/gluster-devel/2016-September/050859.html

Comment 4 Niels de Vos 2016-09-16 18:28:22 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.4, please open a new bug report.

glusterfs-3.8.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/announce/2016-September/000060.html
[2] https://www.gluster.org/pipermail/gluster-users/