Bug 1370868

I will take this review.

Issues
======
1. The spec file URL in the bug differs from the spec file inside the srpm.
   See the diff below.

2. Some files in this package have an ASL 2.0 license notice, and some have
   an LGPLv2+ license notice.  (For an example of the latter, see
   common/src/main/java/org/jboss/as/arquillian/api/ServerSetup.java.)  I think
   the license should be "ASL 2.0 and LGPLv2+", with a note in the spec file
   describing the license breakdown.

3. SHOULD: this is not the latest version.  Versions 1.1.0 and 2.0.0 have been
   released.

4. SHOULD: package includes a non-upstream license file.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "LGPL (v2.1 or later)", "Unknown or
     generated". 3 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It
     is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[!]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: wildfly-arquillian-common-1.0.2-1.fc26.noarch.rpm
          wildfly-arquillian-common-domain-1.0.2-1.fc26.noarch.rpm
          wildfly-arquillian-container-domain-managed-1.0.2-1.fc26.noarch.rpm
          wildfly-arquillian-container-domain-remote-1.0.2-1.fc26.noarch.rpm
          wildfly-arquillian-container-embedded-1.0.2-1.fc26.noarch.rpm
          wildfly-arquillian-container-managed-1.0.2-1.fc26.noarch.rpm
          wildfly-arquillian-container-remote-1.0.2-1.fc26.noarch.rpm
          wildfly-arquillian-javadoc-1.0.2-1.fc26.noarch.rpm
          wildfly-arquillian-parent-1.0.2-1.fc26.noarch.rpm
          wildfly-arquillian-protocol-jmx-1.0.2-1.fc26.noarch.rpm
          wildfly-arquillian-testenricher-msc-1.0.2-1.fc26.noarch.rpm
          wildfly-arquillian-1.0.2-1.fc26.src.rpm
wildfly-arquillian-common.noarch: W: no-documentation
wildfly-arquillian-common-domain.noarch: W: no-documentation
wildfly-arquillian-container-domain-managed.noarch: W: no-documentation
wildfly-arquillian-container-domain-remote.noarch: W: no-documentation
wildfly-arquillian-container-embedded.noarch: W: no-documentation
wildfly-arquillian-container-managed.noarch: W: no-documentation
wildfly-arquillian-container-remote.noarch: W: no-documentation
wildfly-arquillian-parent.noarch: W: no-documentation
wildfly-arquillian-protocol-jmx.noarch: W: no-documentation
wildfly-arquillian-testenricher-msc.noarch: W: no-documentation
12 packages and 0 specfiles checked; 0 errors, 10 warnings.




Rpmlint (installed packages)
----------------------------
wildfly-arquillian-container-domain-remote.noarch: W: no-documentation
wildfly-arquillian-common-domain.noarch: W: no-documentation
wildfly-arquillian-testenricher-msc.noarch: W: no-documentation
wildfly-arquillian-container-managed.noarch: W: no-documentation
wildfly-arquillian-protocol-jmx.noarch: W: no-documentation
wildfly-arquillian-common.noarch: W: no-documentation
wildfly-arquillian-parent.noarch: W: no-documentation
wildfly-arquillian-container-embedded.noarch: W: no-documentation
wildfly-arquillian-container-remote.noarch: W: no-documentation
wildfly-arquillian-container-domain-managed.noarch: W: no-documentation
11 packages and 0 specfiles checked; 0 errors, 10 warnings.



Diff spec file in url and in SRPM
---------------------------------
--- /home/jamesjer/1370868-wildfly-arquillian/srpm/wildfly-arquillian.spec	2016-08-30 20:39:41.006439379 -0600
+++ /home/jamesjer/1370868-wildfly-arquillian/srpm-unpacked/wildfly-arquillian.spec	2016-08-27 09:45:30.000000000 -0600
@@ -139,5 +139,5 @@
 # org.wildfly.core:wildfly-core-feature-pack:zip:1.0.1.Final
 %pom_remove_plugin -r :wildfly-server-provisioning-maven-plugin container-embedded container-managed container-managed-domain
-# ./container-*/target/wildfly-core' must exist
+# ./wildfly-arquillian-1.0.2.Final/container-managed/target/wildfly-core' must exist
 rm -r container-{embedded,managed}/src/test
 


Requires
--------
wildfly-arquillian-container-domain-remote (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(org.jboss.arquillian.core:arquillian-core-api)
    mvn(org.jboss.marshalling:jboss-marshalling-river)
    mvn(org.wildfly.arquillian:wildfly-arquillian-common-domain)

wildfly-arquillian-common-domain (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(org.jboss.arquillian.container:arquillian-container-test-impl-base)
    mvn(org.jboss.arquillian.core:arquillian-core-api)
    mvn(org.jboss.arquillian.protocol:arquillian-protocol-servlet)
    mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-cdi)
    mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-ejb)
    mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-initialcontext)
    mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-resource)
    mvn(org.wildfly.core:wildfly-controller-client)

wildfly-arquillian-testenricher-msc (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(org.jboss.arquillian.container:arquillian-container-test-spi)
    mvn(org.jboss.arquillian.core:arquillian-core-api)
    mvn(org.jboss.arquillian.test:arquillian-test-spi)
    mvn(org.wildfly.core:wildfly-server)

wildfly-arquillian-javadoc (rpmlib, GLIBC filtered):
    javapackages-tools

wildfly-arquillian-container-managed (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(javax.inject:javax.inject)
    mvn(org.jboss.arquillian.core:arquillian-core-api)
    mvn(org.jboss.logging:jboss-logging)
    mvn(org.jboss.marshalling:jboss-marshalling)
    mvn(org.jboss.marshalling:jboss-marshalling-river)
    mvn(org.jboss.remoting:jboss-remoting)
    mvn(org.jboss.remotingjmx:remoting-jmx)
    mvn(org.jboss.sasl:jboss-sasl)
    mvn(org.jboss.xnio:xnio-api)
    mvn(org.jboss.xnio:xnio-nio)
    mvn(org.wildfly.arquillian:wildfly-arquillian-common)
    mvn(org.wildfly.arquillian:wildfly-arquillian-protocol-jmx)
    mvn(org.wildfly.core:wildfly-launcher)

wildfly-arquillian-protocol-jmx (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(org.jboss.arquillian.core:arquillian-core-api)
    mvn(org.jboss.arquillian.core:arquillian-core-spi)
    mvn(org.jboss.arquillian.protocol:arquillian-protocol-jmx)
    mvn(org.wildfly.arquillian:wildfly-arquillian-common)
    mvn(org.wildfly.arquillian:wildfly-arquillian-testenricher-msc)
    mvn(org.wildfly.core:wildfly-jmx)
    mvn(org.wildfly.security:wildfly-security-manager)

wildfly-arquillian-common (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(org.jboss.arquillian.container:arquillian-container-test-impl-base)
    mvn(org.jboss.arquillian.core:arquillian-core-api)
    mvn(org.jboss.arquillian.protocol:arquillian-protocol-servlet)
    mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-cdi)
    mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-ejb)
    mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-initialcontext)
    mvn(org.jboss.arquillian.testenricher:arquillian-testenricher-resource)
    mvn(org.jboss.shrinkwrap.descriptors:shrinkwrap-descriptors-impl-base)
    mvn(org.wildfly.arquillian:wildfly-arquillian-testenricher-msc)
    mvn(org.wildfly.core:wildfly-controller-client)

wildfly-arquillian-parent (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(org.jboss.arquillian.core:arquillian-core-api)
    mvn(org.jboss:jboss-parent:pom:)

wildfly-arquillian-container-embedded (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(org.jboss.arquillian.core:arquillian-core-api)
    mvn(org.jboss.logging:jboss-logging)
    mvn(org.wildfly.arquillian:wildfly-arquillian-common)
    mvn(org.wildfly.arquillian:wildfly-arquillian-protocol-jmx)
    mvn(org.wildfly.core:wildfly-embedded)
    mvn(org.wildfly.core:wildfly-protocol)

wildfly-arquillian-container-remote (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(org.jboss.arquillian.core:arquillian-core-api)
    mvn(org.jboss.marshalling:jboss-marshalling-river)
    mvn(org.wildfly.arquillian:wildfly-arquillian-common)
    mvn(org.wildfly.arquillian:wildfly-arquillian-protocol-jmx)

wildfly-arquillian-container-domain-managed (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(javax.inject:javax.inject)
    mvn(org.jboss.arquillian.core:arquillian-core-api)
    mvn(org.jboss.logging:jboss-logging)
    mvn(org.jboss.sasl:jboss-sasl)
    mvn(org.wildfly.arquillian:wildfly-arquillian-common-domain)
    mvn(org.wildfly.core:wildfly-launcher)



Provides
--------
wildfly-arquillian-container-domain-remote:
    mvn(org.wildfly.arquillian:wildfly-arquillian-container-domain-remote)
    mvn(org.wildfly.arquillian:wildfly-arquillian-container-domain-remote:pom:)
    wildfly-arquillian-container-domain-remote

wildfly-arquillian-common-domain:
    mvn(org.wildfly.arquillian:wildfly-arquillian-common-domain)
    mvn(org.wildfly.arquillian:wildfly-arquillian-common-domain:pom:)
    wildfly-arquillian-common-domain

wildfly-arquillian-testenricher-msc:
    mvn(org.wildfly.arquillian:wildfly-arquillian-testenricher-msc)
    mvn(org.wildfly.arquillian:wildfly-arquillian-testenricher-msc:pom:)
    wildfly-arquillian-testenricher-msc

wildfly-arquillian-javadoc:
    wildfly-arquillian-javadoc

wildfly-arquillian-container-managed:
    mvn(org.wildfly.arquillian:wildfly-arquillian-container-managed)
    mvn(org.wildfly.arquillian:wildfly-arquillian-container-managed:pom:)
    wildfly-arquillian-container-managed

wildfly-arquillian-protocol-jmx:
    mvn(org.wildfly.arquillian:wildfly-arquillian-protocol-jmx)
    mvn(org.wildfly.arquillian:wildfly-arquillian-protocol-jmx:pom:)
    wildfly-arquillian-protocol-jmx

wildfly-arquillian-common:
    mvn(org.wildfly.arquillian:wildfly-arquillian-common)
    mvn(org.wildfly.arquillian:wildfly-arquillian-common:pom:)
    wildfly-arquillian-common

wildfly-arquillian-parent:
    mvn(org.wildfly.arquillian:wildfly-arquillian-parent:pom:)
    wildfly-arquillian-parent

wildfly-arquillian-container-embedded:
    mvn(org.wildfly.arquillian:wildfly-arquillian-container-embedded)
    mvn(org.wildfly.arquillian:wildfly-arquillian-container-embedded:pom:)
    wildfly-arquillian-container-embedded

wildfly-arquillian-container-remote:
    mvn(org.wildfly.arquillian:wildfly-arquillian-container-remote)
    mvn(org.wildfly.arquillian:wildfly-arquillian-container-remote:pom:)
    wildfly-arquillian-container-remote

wildfly-arquillian-container-domain-managed:
    mvn(org.wildfly.arquillian:wildfly-arquillian-container-domain-managed)
    mvn(org.wildfly.arquillian:wildfly-arquillian-container-domain-managed:pom:)
    wildfly-arquillian-container-domain-managed



Source checksums
----------------
https://github.com/wildfly/wildfly-arquillian/archive/1.0.2.Final/wildfly-arquillian-1.0.2.Final.tar.gz :
  CHECKSUM(SHA256) this package     : 9e1621dfc09856f475814735fb3637c49c1c70840bfcaa5d5195532bae97200a
  CHECKSUM(SHA256) upstream package : 9e1621dfc09856f475814735fb3637c49c1c70840bfcaa5d5195532bae97200a


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1370868 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

(In reply to Jerry James from comment #2)
> Issues
> ======
> 1. The spec file URL in the bug differs from the spec file inside the srpm.
>    See the diff below.

Done

> 2. Some files in this package have an ASL 2.0 license notice, and some have
>    an LGPLv2+ license notice.  (For an example of the latter, see
>    common/src/main/java/org/jboss/as/arquillian/api/ServerSetup.java.)  I
> think
>    the license should be "ASL 2.0 and LGPLv2+", with a note in the spec file
>    describing the license breakdown.

Done

> 3. SHOULD: this is not the latest version.  Versions 1.1.0 and 2.0.0 have
> been
>    released.

I am not interested for now to upgrade the package to 2.0.0.Final.
This release id used in wildfly 10.1.0.Final

> 4. SHOULD: package includes a non-upstream license file.

Upstream already fixed the problem with
https://github.com/wildfly/wildfly-arquillian/pull/60
but the patch available is not applicable for this release

Spec URL: https://gil.fedorapeople.org/wildfly-arquillian.spec
SRPM URL: https://gil.fedorapeople.org/wildfly-arquillian-1.0.2-2.fc24.src.rpm

Okay, looks good.  This package is APPROVED.

Thanks for the review!

create new SCM request/s:
https://admin.fedoraproject.org/pkgdb/package/requests/7580
https://admin.fedoraproject.org/pkgdb/package/requests/7581

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/wildfly-arquillian

wildfly-arquillian-1.0.2-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2ed5685e9b

wildfly-arquillian-1.0.2-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2ed5685e9b

wildfly-arquillian-1.0.2-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.