Bug 1370910

Summary:	Remove collection of @rxRate @txRate from vdsm and from db
Product:	[oVirt] ovirt-engine	Reporter:	Shirly Radco <sradco>
Component:	General	Assignee:	Marcin Mirecki <mmirecki>
Status:	CLOSED NOTABUG	QA Contact:	Meni Yakove <myakove>
Severity:	medium	Docs Contact:
Priority:	high
Version:	4.1.0	CC:	bugs, danken, gklein, mmirecki, oourfali, sradco, ylavi
Target Milestone:	ovirt-4.1.0-beta	Keywords:	CodeChange
Target Release:	---	Flags:	rule-engine: ovirt-4.1+ rule-engine: planning_ack+ danken: devel_ack+ ykaul: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-12-07 13:12:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1370908, 1370911, 1370915

Description Shirly Radco 2016-08-28 09:46:29 UTC

Description of problem:
Remove collection of  @rxRate  @txRate from vdsm and from db.
Engine uses the raw rx and tx values.

Comment 1 Shirly Radco 2016-08-28 10:07:32 UTC

For hosts and vms.

Comment 2 Dan Kenigsberg 2016-08-31 10:34:21 UTC

I believe that this is already done. Marcin, please correct me if I'm wrong.

Comment 3 Marcin Mirecki 2016-09-02 06:47:15 UTC

This was removed in:
vdsm:
https://gerrit.ovirt.org/#/c/59544/
engine:
https://gerrit.ovirt.org/#/c/59508/

We now calculate tx/rx rate on the engine using the raw rx/tx data received from vdsm.

Comment 4 Shirly Radco 2016-11-10 09:01:18 UTC

I see this was not removed from the database.Does this require a new bug?

Comment 5 Dan Kenigsberg 2016-11-10 09:21:46 UTC

Do you see any content in these fields?

I suspect that we're missing a sql script to remove these now-unused columns from db. If there are values inside, we have an even bigger cleanup to do

Comment 6 Shirly Radco 2016-11-30 10:48:01 UTC

I believe there is no upgrade script that removes these columns.
Not sure about the data. I just run the schema.sh script.

Comment 7 Marcin Mirecki 2016-12-07 10:38:27 UTC

Rx/tx rate is not sent from vdsm anymore, but we still have a need for them. The rate is still shown to the user in the UI.
rx/tx rate is now calculated in the engine (NetworkStatisticsBuilder computeRatePercentage) whenever HostMonitoring runs GetStatsVDSCommand. This data must then be stored in the db, in order to be available in the UI.
We therefore need the rx/tx rate columns in the db.