Bug 1371085

Summary: Confusing Capsules with feature pulp and pulp-node
Product: Red Hat Satellite Reporter: Peter Vreman <peter.vreman>
Component: InstallerAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED CURRENTRELEASE QA Contact: Katello QA List <katello-qa-list>
Severity: high Docs Contact:
Priority: high    
Version: 6.2.0CC: bkearney, jcallaha, lzap, mtenheuv, rvdwees, stbenjam
Target Milestone: UnspecifiedKeywords: Reopened, Triaged, UserExperience
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-11-06 18:51:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1122832    

Description Peter Vreman 2016-08-29 09:56:42 UTC 
Description of problem:
When you create a capsule with the pulp feature there is no warning that it is wrong as you normally only need the pulp-node feature.
Then once you have the external capsule with the pulp feature enabled then synchronize is not working anymore as it errors with

"Action not allowed for the default capsule"

This is for the end-user a confusing error message and does not help the end-user to solve the problem.

After some googling the issue http://projects.theforeman.org/issues/9209 can be found making a remark that the feature "Pulp" is checked for the Synchronize feature to be enabled.

For the end-user this is all confusing.
Recommended improvements to not confuse the end-user:
- Rename feature "Pulp" to "Pulp-Master" to make it clear it is the master feature and not the node feature
- Rename capsule-installer option "--foreman-proxy-plugin-pulp-enabled=true" to "--foreman-proxy-plugin-pulp-master-enabled=true"
- Rename feature "--foreman-proxy-plugin-pulp-pulpnode-enabled" to --foreman-proxy-plugin-pulpnode-enabled" to make it clear it is a second feature indepenednt of the "Pulp-Master" feature
- Improved error message, stating that a Capsule with the feature "Pulp-Master" does not need to be synchronized as it is the master.
- Provide a warning that registering a second Capsule with the feature "Pulp-Master" is not allowed


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 2 Stephen Benjamin 2016-10-13 16:14:36 UTC 
Created redmine issue http://projects.theforeman.org/issues/16917 from this bug
Comment 6 Peter Vreman 2018-07-10 10:23:25 UTC 
In Sat6.3 looking at the help page of the satellite-installer for capsule i do not see any 'pulpnode' anymore:

----
[crash/LI] root@li-lc-1589:~# satellite-installer --help --scenario capsule | grep pulp
    --clear-pulp-content          This option will clear all Pulp content from disk located in '/var/lib/pulp/content/'. (default: false)
    --[no-]enable-foreman-proxy-plugin-pulp Enable 'foreman_proxy_plugin_pulp' puppet module (default: true)
= Module foreman_proxy_plugin_pulp:
[crash/LI] root@li-lc-1589:~#
----

I think this BZ can be closed as being delivered in 6.3 already
Comment 7 Bryan Kearney 2018-07-11 15:47:06 UTC 
Thank you Peter. Closing this out per Comment 6.
Comment 9 Peter Vreman 2018-11-02 16:24:45 UTC 
On Sat6.4 i have the following options with pulp:
--------------
root@li-lc-2223:~# satellite-installer --help --scenario capsule | grep pulp
    --clear-pulp-content          This option will clear all Pulp content from disk located in '/var/lib/pulp/content/'. (default: false)
    --[no-]enable-foreman-proxy-plugin-pulp Enable 'foreman_proxy_plugin_pulp' puppet module (default: true)
= Module foreman_proxy_plugin_pulp:
--------------

For me this is fixed in Sat6.4
Comment 10 Bryan Kearney 2018-11-06 18:51:27 UTC 
I am closing this out based on comment 9. Thank you Peter!