Bug 1371196

Summary:	segment fault while join thread reaper_thr in fini()
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	upcall	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.15	CC:	bugs, jthottan
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.16	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1369524
Clones:	1384460 (view as bug list)		Environment:
Last Closed:	2016-10-17 09:04:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1369524
Bug Blocks:	1384460

Description Niels de Vos 2016-08-29 14:27:25 UTC

+++ This bug was initially created as a clone of Bug #1369524 +++

Description of problem:

reaper_thr thread may not be started according to option 'cache-invalidation', if it's not started, the following code in fini() will cause segment fault:

        priv->fini = 1; 

        pthread_join (priv->reaper_thr, NULL);

--- Additional comment from Worker Ant on 2016-08-23 18:30:26 CEST ---

REVIEW: http://review.gluster.org/15298 (features/upcall: segment fault while join thread reaper_thr in fini()) posted (#1) for review on master by Anonymous Coward

--- Additional comment from Worker Ant on 2016-08-25 22:50:09 CEST ---

REVIEW: http://review.gluster.org/15298 (features/upcall: segment fault while join thread reaper_thr in fini()) posted (#2) for review on master by Niels de Vos (ndevos)

--- Additional comment from Worker Ant on 2016-08-29 14:13:54 CEST ---

COMMIT: http://review.gluster.org/15298 committed in master by Jeff Darcy (jdarcy) 
------
commit 7f0042dce94edb58c92662d9e4f852ba006d12dc
Author: Ryan Ding <ryan.ding>
Date:   Wed Aug 24 00:24:30 2016 +0800

    features/upcall: segment fault while join thread reaper_thr in fini()
    
    reaper_thr thread may not be started according to option
    'cache-invalidation', if it's not started, join it in fini will cause a
    segment fault.
    
    Change-Id: I1c145a5feb137767880a08e79f810537283fb6b9
    BUG: 1369524
    Signed-off-by: Ryan Ding <ryan.ding>
    [ndevos: check .reaper_init_done and make it a boolean]
    Reviewed-on: http://review.gluster.org/15298
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: soumya k <skoduri>
    Reviewed-by: Niels de Vos <ndevos>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2016-08-29 14:31:02 UTC

REVIEW: http://review.gluster.org/15337 (features/upcall: segment fault while join thread reaper_thr in fini()) posted (#1) for review on release-3.7 by Niels de Vos (ndevos)

Comment 2 Worker Ant 2016-09-05 09:07:25 UTC

COMMIT: http://review.gluster.org/15337 committed in release-3.7 by Niels de Vos (ndevos) 
------
commit 337fb7f4e14240fa6553e34094bc07f24fe897b6
Author: Niels de Vos <ndevos>
Date:   Mon Aug 29 16:30:16 2016 +0200

    features/upcall: segment fault while join thread reaper_thr in fini()
    
    reaper_thr thread may not be started according to option
    'cache-invalidation', if it's not started, join it in fini will cause a
    segment fault.
    
    Cherry picked from commit 7f0042dce94edb58c92662d9e4f852ba006d12dc:
    > Change-Id: I1c145a5feb137767880a08e79f810537283fb6b9
    > BUG: 1369524
    > Signed-off-by: Ryan Ding <ryan.ding>
    > [ndevos: check .reaper_init_done and make it a boolean]
    > Reviewed-on: http://review.gluster.org/15298
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: soumya k <skoduri>
    > Reviewed-by: Niels de Vos <ndevos>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    
    Change-Id: I1c145a5feb137767880a08e79f810537283fb6b9
    BUG: 1371196
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/15337
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Ryan Ding <ryan.ding>
    Reviewed-by: soumya k <skoduri>

Comment 3 Kaushal 2016-10-17 09:04:48 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.16, please open a new bug report.

glusterfs-3.7.16 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-October/051187.html
[2] https://www.gluster.org/pipermail/gluster-users/