Bug 1371340
| Summary: | Review Request: miniflux - Minimalist web based news reader | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Bost <bostrt> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | o.lemasle, package-review, rbost |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | Trivial | ||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-03-30 00:49:09 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 177841 | ||
|
Description
Robert Bost
2016-08-30 00:13:01 UTC
Updated default miniflux.conf VHost so that it listens on 127.0.0.1. This is because miniflux ships with default credentials. You need to get sponsored into the packager group to be able to send packages into Fedora repository. Please follow the general guidelines: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group This package seems to have some issues (see below). I'm not yet a maintainer, as I haven't been sponsored, so this comment is unofficial. - The source tarball includes multiple bundled libraries in the "vendor" directory, like zendframework, picofeed, etc. According to the Fedora Packaging Guidelines, these should not be bundled, as system libraries should be used. - Config file /usr/share/miniflux/config.php should not be under /usr - As noted in the rpmlint output, this package includes .htaccess files, which should be replaced by central configuration in /etc/, which is less vulnerable to attack (See https://fedoraproject.org/wiki/Apache_HTTP_Server#Installing_webapps) Additionally, new releases of Miniflux have been released since the original upload of the SPEC (last: 1.2.1) Thanks for the input. I'll proceed with making these adjustments (in addition to updating to latest version). Putting this package into Fedora Copr for now. There's quite a bit of work needed to pull out the vendor libs into other packages. Closing this bz for the time being. |