Bug 1371539
| Summary: | Quota version not changing in the quota.conf after upgrading to 3.7.1 from 3.6.1 | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Manikandan <mselvaga> | |
| Component: | glusterd | Assignee: | Raghavendra G <rgowdapp> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
| Severity: | medium | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | amukherj, bugs, manikandancs333, rcyriac, rhinduja, rnalakka, smohan, storage-qa-internal | |
| Target Milestone: | --- | Keywords: | Triaged | |
| Target Release: | --- | |||
| Hardware: | All | |||
| OS: | All | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.10.0 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | 1367472 | |||
| : | 1392715 1392716 1392718 (view as bug list) | Environment: | ||
| Last Closed: | 2017-03-06 17:23:44 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1367472 | |||
| Bug Blocks: | 1392715, 1392716, 1392718 | |||
|
Comment 1
Worker Ant
2016-08-30 12:43:19 UTC
REVIEW: http://review.gluster.org/15352 (glusterd/quota: upgrade quota.conf file during an upgrade) posted (#2) for review on master by Manikandan Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/15352 (glusterd/quota: upgrade quota.conf file during an upgrade) posted (#3) for review on master by Manikandan Selvaganesh (manikandancs333) glusterd/quota: upgrade quota.conf file during an upgrade Problem ======= When quota is enabled on 3.6, it will have quota conf version in quota.conf as v1.1. This node gets upgraded to 3.7 but it will still have quota conf version as v1.1 until a quota enable/disable/set limit is initiated. When this is not initiated and when this node tries to peer probe a node which is a fresh install of 3.7 (which will have quota conf version as v1.2), then this will result in "Peer rejected" state. REVIEW: http://review.gluster.org/15352 (glusterd/quota: upgrade quota.conf file during an upgrade) posted (#4) for review on master by sanoj-unnikrishnan (sunnikri) REVIEW: http://review.gluster.org/15352 (glusterd/quota: upgrade quota.conf file during an upgrade) posted (#5) for review on master by sanoj-unnikrishnan (sunnikri) COMMIT: http://review.gluster.org/15352 committed in master by Atin Mukherjee (amukherj) ------ commit 4b2cff614462508eef529c5d128e0974720e3f50 Author: Manikandan Selvaganesh <mselvaga> Date: Tue Aug 30 17:53:09 2016 +0530 glusterd/quota: upgrade quota.conf file during an upgrade Problem ======= When quota is enabled on 3.6, it will have quota conf version in quota.conf as v1.1. This node gets upgraded to 3.7 but it will still have quota conf version as v1.1 until a quota enable/disable/set limit is initiated. When this is not initiated and when this node tries to peer probe a node which is a fresh install of 3.7 (which will have quota conf version as v1.2), then this will result in "Peer rejected" state. This patch fixes the issue. Solution ======== When an upgrade happens from 3.6 to 3.7, quota.conf file needs to be modified as well. With 3.6, in quota.conf the version will be v1.1 and it needs to be changed to v1.2 from 3.7. This is because in 3.7, inode quota feature is introduced. So when an op-version bumpup happens quota.conf needs to be upgraded with quota conf version v1.2 and all the 16 byte uuid needs to be changed to 17 bytes uuid as well. Previously, when the cluster version is upgraded to 3.7, the quota.conf got upgraded as well. But, the upgradation was done only when quota enable/disable/set limit is done. With this patch, the upgradation is done during a cluster op version bump up as well. Change-Id: Idb5ba29d3e1ea0e45c85d87c952c75da9e0f99f0 BUG: 1371539 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/15352 Tested-by: Atin Mukherjee <amukherj> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Atin Mukherjee <amukherj> REVIEW: http://review.gluster.org/15791 (glusterd/quota: upgrade quota.conf file during an upgrade) posted (#1) for review on release-3.8 by sanoj-unnikrishnan (sunnikri) This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report. glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html [2] https://www.gluster.org/pipermail/gluster-users/ |