Bug 1371543

Summary:	Add cache invalidation stat in profile info
Product:	[Community] GlusterFS	Reporter:	Poornima G <pgurusid>
Component:	io-stats	Assignee:	Poornima G <pgurusid>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	FutureFeature, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-27 18:20:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Poornima G 2016-08-30 12:49:56 UTC

Description of problem:
Currently only the fop counts and latency gets printed in the profile info. It would help in debugging if the upcall notifications are also part of profile info.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2016-08-30 12:51:26 UTC

REVIEW: http://review.gluster.org/15193 (io-stats: Add stats for upcall notifications) posted (#5) for review on master by Poornima G (pgurusid)

Comment 2 Worker Ant 2016-08-31 09:15:26 UTC

REVIEW: http://review.gluster.org/15193 (io-stats: Add stats for upcall notifications) posted (#6) for review on master by Poornima G (pgurusid)

Comment 3 Worker Ant 2016-09-01 03:18:46 UTC

COMMIT: http://review.gluster.org/15193 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit ee0d8ca53f685f8f27c93b3d7c808f2a78c1ae43
Author: Poornima G <pgurusid>
Date:   Wed Aug 17 20:19:59 2016 +0530

    io-stats: Add stats for upcall notifications
    
    With this patch, there will be additional entries seen in
    the profile info:
    
    UPCALL : Total number of upcall events that were sent from
             the brick(in brick profile), and number of upcall
             notifications recieved by client(in client profile)
    
    Cache invalidation events:
    -------------------------
    CI_IATT : Number of upcalls that were cache invalidation and
             had one of the IATT_UPDATE_FLAGS set. This indicates
             that one of the iatt value was changed.
    
    CI_XATTR : Number of upcalls that were cache invalidation, and
             had one of the UP_XATTR or UP_XATTR_RM set. This indicates
             that an xattr was updated or deleted.
    
    CI_RENAME : Number of upcalls that were cache invalidation,
             resulted by the renaming of a file or directory
    
    CI_UNLINK : Number of upcalls that were cache invalidation,
             resulted by the unlink of a file.
    
    CI_FORGET : Number of upcalls that were cache invalidation,
             resulted by the forget of inode on the server side.
    
    Lease events:
    ------------
    LEASE_RECALL : Number of lease recalls sent by the brick (in
             brick profile), and number of lease recalls recieved
             by client(in client profile)
    
    Note that the sum of CI_IATT, CI_XATTR, CI_RENAME, CI_UNLINK,
    CI_FORGET, LEASE_RECALL may not be equal to UPCALL. This is
    because, each cache invalidation can carry multiple flags.
    Eg:
    - Every CI_XATTR will have CI_IATT
    - Every CI_UNLINK will also increment CI_IATT as link count is an
    iatt attribute.
    
    Also UP_PARENT_DENTRY_FLAGS is currently not accounted for,
    as CI_RENAME and CI_UNLINK will always have the flag
    UP_PARENT_DENTRY_FLAGS
    
    Change-Id: Ieb8cd21dde2c4c7618f12d025a5e5156f9cc0fe9
    BUG: 1371543
    Signed-off-by: Poornima G <pgurusid>
    Reviewed-on: http://review.gluster.org/15193
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Rajesh Joseph <rjoseph>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 4 Shyamsundar 2017-03-27 18:20:24 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/