Bug 1371794

Summary: Hidden flag has no impact on smart variables when using Hammer CLI
Product: Red Hat Satellite Reporter: Oleksandr Shtaier <oshtaier>
Component: Smart VariablesAssignee: orabin
Status: CLOSED ERRATA QA Contact: Shimon Shtein <sshtein>
Severity: medium Docs Contact:
Priority: high    
Version: 6.2.0CC: bbuckingham, orabin, sshtein
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-21 16:51:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Oleksandr Shtaier 2016-08-31 06:55:49 UTC
Description of problem:
When we apply hidden flag on smart variables in UI we can clearly see that default value is substituted by '*****' marks, but when we do the same action in CLI we cannot see any change to default value or to any other values:

hammer -v -u admin -p changeme smart-variable info --name="lItINDxCih"
Id:              74
Name:            lItINDxCih
Default Value:   holFhLlcDy
Type:            string
Puppet class:    ntp
Description:     
Hidden Value?:   true
Validator:       
    Type: 
    Rule:
Override values: 
    Merge overrides:     no
    Merge default value: no
    Avoid duplicates:    no
    Order:               fqdn, hostgroup, os, domain
    Values:
Created at:      2016/08/31 06:48:49
Updated at:      2016/08/31 06:48:49

Version-Release number of selected component (if applicable):
6.2.1

How reproducible:
Always

Steps to Reproduce:
1. Create new smart variable with default value
2. Change 'hidden-value' flag state to true

Actual results:
Nothing is hidden

Expected results:
default value should be hidden

Additional info:

Comment 2 orabin 2016-12-13 09:36:59 UTC
Created redmine issue http://projects.theforeman.org/issues/17652 from this bug

Comment 4 Satellite Program 2017-01-26 09:07:22 UTC
Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/17652 has been resolved.

Comment 5 Shimon Shtein 2017-08-16 09:21:14 UTC
Verified:

[root tomcat]# hammer -v smart-variable info --name="hidden_var"
Warning: Option --name is deprecated. Use --variable instead
Id:              14
Variable:        hidden_var
Default Value:   *****
Type:            string
Puppet class:    access_insights_client
Description:     
Hidden Value?:   true
Validator:       
    Type: 
    Rule:
Override values: 
    Merge overrides:     no
    Merge default value: no
    Avoid duplicates:    no
    Order:               
      fqdn
      hostgroup
      os
      domain
    Values:
Created at:      2017/08/16 09:17:43
Updated at:      2017/08/16 09:17:43

Sat version: 6.3.0-16.0.beta.el7sat

Comment 6 Satellite Program 2018-02-21 16:51:07 UTC
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA.
> 
> For information on the advisory, and where to find the updated files, follow the link below.
> 
> If the solution does not work for you, open a new bug report.
> 
> https://access.redhat.com/errata/RHSA-2018:0336