Bug 1371833

Summary:	OVF data upload to disk fails because of ClassCastException
Product:	[oVirt] ovirt-engine	Reporter:	Liron Aravot <laravot>
Component:	BLL.Storage	Assignee:	Liron Aravot <laravot>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Kevin Alon Goldblatt <kgoldbla>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.1.0	CC:	acanan, amureini, bugs, laravot, mburman, ratamir, tnisan
Target Milestone:	ovirt-4.1.0-alpha	Keywords:	Regression
Target Release:	4.1.0.2	Flags:	rule-engine: ovirt-4.1+ rule-engine: blocker+ rule-engine: planning_ack+ rule-engine: devel_ack+ ratamir: testing_ack+
Hardware:	x86_64
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1371164	Environment:
Last Closed:	2017-02-01 14:39:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1371164
Bug Blocks:

Description Liron Aravot 2016-08-31 08:31:52 UTC

Description of problem:
Ovf data on disks isn't uploaded because of class cast exception.

How reproducible:
100

Steps to Reproduce:
1. Have a setup with one host, two storage domains.
2. Create a VM with a disk on the non master data domain
3. Deactivate the non master data domain

Actual results:
OVF upload fails on UploadStreamVDSCommand on class cast exception

Expected results:
Should work as expected

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-08-29 12:40:19 EDT ---

Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

--- Additional comment from Allon Mureinik on 2016-08-29 16:17:59 EDT ---

Steps to reproduce? logs?

--- Additional comment from Michael Burman on 2016-08-30 01:41 EDT ---



--- Additional comment from Michael Burman on 2016-08-30 01:42:42 EDT ---

(In reply to Allon Mureinik from comment #2)
> Steps to reproduce? logs?

Create new VM with new disk in master 4.1

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-08-30 04:12:56 EDT ---

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

--- Additional comment from Allon Mureinik on 2016-08-30 04:30:16 EDT ---

(In reply to Michael Burman from comment #4)
> (In reply to Allon Mureinik from comment #2)
> > Steps to reproduce? logs?
> 
> Create new VM with new disk in master 4.1

webadmin? userportal?

--- Additional comment from Michael Burman on 2016-08-30 04:44:40 EDT ---

Webadmin

--- Additional comment from Allon Mureinik on 2016-08-30 05:19:25 EDT ---

Not sure if related, but I see this CastClassException in the log that's definitely not OK:

2016-08-30 04:02:50,563 ERROR [org.ovirt.engine.core.vdsbroker.irsbroker.UploadStreamVDSCommand] (DefaultQuartzScheduler9) [4bd40f7b] Command 'UploadStreamVDSCommand(HostName = orchid-vds1.qa.lab.tlv.redhat.com, UploadStreamVDSCommandParameters:{runAsync='true', hostId='a4f67654-459e-4010-a811-06f86c3fa727'})' execution failed: java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.Long
2016-08-30 04:02:50,563 INFO  [org.ovirt.engine.core.vdsbroker.irsbroker.UploadStreamVDSCommand] (DefaultQuartzScheduler9) [4bd40f7b] FINISH, UploadStreamVDSCommand, log id: 24802341
2016-08-30 04:02:50,563 ERROR [org.ovirt.engine.core.bll.storage.ovfstore.UploadStreamCommand] (DefaultQuartzScheduler9) [4bd40f7b] Command 'org.ovirt.engine.core.bll.storage.ovfstore.UploadStreamCommand' failed: EngineException: org.ovirt.engine.core.vdsbroker.vdsbroker.VDSNetworkException: java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.Long (Failed with error VDS_NETWORK_ERROR and code 5022)

Liron - any insight on this?

--- Additional comment from Tal Nisan on 2016-08-30 10:09:01 EDT ---

Liron, the bug has nothing to do with this error bug this error should be investigated regardless, please try to see why OVF upload fails on ClassCastException and open a separate bug if needed

Comment 1 Red Hat Bugzilla Rules Engine 2016-08-31 08:32:04 UTC

Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 2 Red Hat Bugzilla Rules Engine 2016-08-31 09:19:33 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 3 Red Hat Bugzilla Rules Engine 2016-08-31 09:24:47 UTC

Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 4 Red Hat Bugzilla Rules Engine 2016-08-31 11:13:19 UTC

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 5 Sandro Bonazzola 2016-12-12 13:58:17 UTC

The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.

Comment 6 Kevin Alon Goldblatt 2016-12-14 14:50:29 UTC

Verified with the following code:
----------------------------------------
ovirt-engine-4.1.0-0.2.master.20161212172238.gitea103bd.el7.centos.noarch
vdsm-4.18.999-1147.git951e122.el7.centos.x86_64

Verified with the following scenario:
---------------------------------------
Steps to Reproduce:
1. Have a setup with one host, two storage domains.
2. Create a VM with a disk on the non master data domain
3. Set the non master data domain to maintenance

Actual results:
OVF upload is successful and no exceptions are thrown.


From Engine Log:
-----------------------
2016-12-14 16:24:11,956+02 INFO  [org.ovirt.engine.core.bll.storage.ovfstore.UploadStreamCommand] (org.ovirt.thread.pool-6-thread-19) [368b2a7] Ending command 'org.ovirt.engine.core.bll.st
orage.ovfstore.UploadStreamCommand' successfully.


Moving to VERIFIED!