Bug 1371845

Summary: enable tests
Product: [Fedora] Fedora Reporter: Germano Massullo <germano.massullo>
Component: rubygem-pcaprubAssignee: Germano Massullo <germano.massullo>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 26CC: germano.massullo
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-pcaprub-0.12.4-3.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-10 16:02:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1348202    

Description Germano Massullo 2016-08-31 09:02:59 UTC
Description of problem:
personal reminder


https://bugzilla.redhat.com/show_bug.cgi?id=1348202#c7
Vít Ondruch:
I have a few comments.

* The test suite is not executed
  - It is always good idea to execute the test suite to make sure the package
    works. There is test suite available in upstream repository, so it should
    not be a problem.

* Please remove the binary extension from the source tree
  - Please see [1] how to do it and for the link to associated BZ with reasoning.

* License
  - The license field does not contain valid Fedora identifier. Please see [2]
    and pick the correct one (likely LGPLv2?)




[1] http://pkgs.fedoraproject.org/cgit/rpms/rubygem-sqlite3.git/tree/rubygem-sqlite3.spec#n49
[2] https://fedoraproject.org/wiki/Licensing:Main#Software_License_List

======================

======================
https://bugzilla.redhat.com/show_bug.cgi?id=1348202#c8
Vít Ondruch:

BTW, for the EPEL7, you probably want to follow these guidelines [1], which are referenced on the top of regular Fedora packaging guidelines.


[1] https://fedoraproject.org/w/index.php?title=Packaging:Ruby&oldid=363159

======================

Comment 1 Germano Massullo 2016-08-31 09:22:32 UTC
Concerning second point of first message, the piece of code is missing because gem2rpm has not inserted it into the spec file, but it should have done it

Comment 2 Igor Gnatenko 2016-08-31 09:46:49 UTC
gem2rpm is not silver bullet. It just helps to generate initial spec file.

Comment 3 Germano Massullo 2016-08-31 09:57:36 UTC
(In reply to Igor Gnatenko from comment #2)
> gem2rpm is not silver bullet. It just helps to generate initial spec file.

By reading Victor statement, gem2rpm should do it

[10:57] <vondruch> IOW if you used gem2rpm, you would have the code in place

Comment 4 Germano Massullo 2016-08-31 10:19:43 UTC
(In reply to Germano Massullo from comment #3)
> (In reply to Igor Gnatenko from comment #2)
> > gem2rpm is not silver bullet. It just helps to generate initial spec file.
> 
> By reading Victor statement, gem2rpm should do it
> 
> [10:57] <vondruch> IOW if you used gem2rpm, you would have the code in place

My fault, I tried gem2rpm using celluloid-essentials-0.20.5.gem that is a noarch gem, so there is no extension therefore there is nothing to remove.

Then I tried again using gem2rpm on rubygem-pcaprub and I got 
=====
# Prevent dangling symlink in -debuginfo (rhbz#878863).
rm -rf %{buildroot}%{gem_instdir}/ext/
=====

Comment 5 Germano Massullo 2016-08-31 14:44:46 UTC
=== TO DO ===
1) Tests: use [1]

2) EPEL7: use resources from Vít Ondruch's message

[1]: http://pkgs.fedoraproject.org/cgit/rpms/rubygem-tilt.git/tree/rubygem-tilt.spec#n92

Comment 6 Germano Massullo 2016-09-21 11:32:15 UTC
=== TO DO ===
1) Tests: use [1]

[1]: http://pkgs.fedoraproject.org/cgit/rpms/rubygem-tilt.git/tree/rubygem-tilt.spec#n92

=== DONE ===
2) EPEL7: dropped branch

Comment 7 Fedora End Of Life 2016-11-25 09:32:47 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 8 Fedora End Of Life 2017-02-28 10:10:47 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 9 Fedora Update System 2017-04-06 11:10:51 UTC
rubygem-pcaprub-0.12.4-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f58c5ff155

Comment 10 Fedora Update System 2017-04-06 22:23:34 UTC
rubygem-pcaprub-0.12.4-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f58c5ff155

Comment 11 Fedora Update System 2017-04-10 16:02:32 UTC
rubygem-pcaprub-0.12.4-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.