Bug 137190

Summary:	Empty VG name: command still attempted
Product:	Red Hat Enterprise Linux 4	Reporter:	Derek Anderson <danderso>
Component:	system-config-lvm	Assignee:	Jim Parsons <jparsons>
Status:	CLOSED RAWHIDE	QA Contact:	Jim Parsons <jparsons>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.0	CC:	cluster-maint, danderso
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2004-11-04 15:42:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Derek Anderson 2004-10-26 16:27:10 UTC

Description of problem:
If you attempt to create a VG with a blank name you get the error
message, but then the command is still attempted.  It should not. 
Just need a return statement in InputController.py after the failure
condition, like the rest of the input checks:

~224:
    proposed_name = self.new_vg_name.get_text().strip()
    if proposed_name == "":
      self.errorMessage(MUST_PROVIDE_VG_NAME)

Version-Release number of selected component (if applicable):
system-config-lvm-0.9.1-2.5

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jim Parsons 2004-10-29 21:49:06 UTC

Fixed in 0.9.4-1.0

Comment 2 Derek Anderson 2004-11-04 15:42:36 UTC

Verified in system-config-lvm-0.9.6-1.0:

Get the error message, "A Name must be provided for the new Volume
Group", click OK, you go back to the New Volume Group dialog.  Much
better.