Bug 1371912
Summary: | `gluster system:: uuid get` hangs | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Ravishankar N <ravishankar> |
Component: | cli | Assignee: | Ravishankar N <ravishankar> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 3.8 | CC: | bugs |
Target Milestone: | --- | Keywords: | Triaged |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | glusterfs-3.8.4 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | 1371775 | Environment: | |
Last Closed: | 2016-09-16 18:28:44 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1371775 | ||
Bug Blocks: |
Description
Ravishankar N
2016-08-31 12:21:32 UTC
REVIEW: http://review.gluster.org/15376 (cli: Fix double unref of dict) posted (#1) for review on release-3.8 by Ravishankar N (ravishankar) REVIEW: http://review.gluster.org/15376 (cli: Fix double unref of dict) posted (#2) for review on release-3.8 by Ravishankar N (ravishankar) REVIEW: http://review.gluster.org/15376 (cli: Fix double unref of dict) posted (#3) for review on release-3.8 by Ravishankar N (ravishankar) COMMIT: http://review.gluster.org/15376 committed in release-3.8 by Atin Mukherjee (amukherj) ------ commit f2ce05561c29c48640b72d0e813dd93b0282bd5e Author: Ravishankar N <ravishankar> Date: Wed Aug 31 10:47:45 2016 +0530 cli: Fix double unref of dict Backport of http://review.gluster.org/#/c/15368/ Problem: `gluster system:: uuid get` hangs due to double unref of dict. Fix: Remove the unnecessary unref in cli_cmd_uuid_get_cbk(). In the said function, if calling proc->fn() is sucessful, the dict is automatically unrefed in its cbk as a part of cli_local_wipe(). If calling proc->fn() fails, then CLI_STACK_DESTROY() takes care of the unref. Change-Id: Ib656d200f14a27415b36794a0bdadfe36b0d5306 BUG: 1371912 Signed-off-by: Ravishankar N <ravishankar> (cherry picked from commit 2d3292fd29884b16cac058f937f91cfda197eca6) Reviewed-on: http://review.gluster.org/15376 Smoke: Gluster Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Atin Mukherjee <amukherj> All 3.8.x bugs are now reported against version 3.8 (without .x). For more information, see http://www.gluster.org/pipermail/gluster-devel/2016-September/050859.html This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.4, please open a new bug report. glusterfs-3.8.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/announce/2016-September/000060.html [2] https://www.gluster.org/pipermail/gluster-users/ |