Bug 1372123

*UPDATED INFO*

- Fixed missing hicolor app icons 
- Added icon-updating scriptlets 

SRPM: https://kojipkgs.fedoraproject.org//work/tasks/3213/15473213/pacmanager-4.5.5.7-2.fc24.src.rpm
RPM: https://kojipkgs.fedoraproject.org//work/tasks/3213/15473213/pacmanager-4.5.5.7-2.fc24.noarch.rpm

The rest of links remain the same.

I'll try to help review this in the next day or 2

$ rpmlint pacmanager
pacmanager.noarch: W: spelling-error Summary(en_US) multi -> mulch, mufti
pacmanager.noarch: W: spelling-error %description -l en_US rsh -> rah, rs, sh
pacmanager.noarch: W: spelling-error %description -l en_US automator -> automaton, automate, automatism
pacmanager.noarch: W: spelling-error %description -l en_US mRemoteNG -> remoteness
pacmanager.noarch: W: incoherent-version-in-changelog 4.5.5.7 ['4.5.5.7-2.fc24', '4.5.5.7-2']
pacmanager.noarch: E: standard-dir-owned-by-package /usr/share/man
pacmanager.noarch: E: standard-dir-owned-by-package /usr/share/icons
pacmanager.noarch: W: non-conffile-in-etc /etc/bash_completion.d/pacmanager
pacmanager.noarch: E: standard-dir-owned-by-package /usr/share/man/man1
pacmanager.noarch: W: no-manual-page-for-binary pacmanager_from_putty
pacmanager.noarch: W: no-manual-page-for-binary pacmanager_from_mcm
1 packages and 0 specfiles checked; 3 errors, 8 warnings.

So, the biggest issue here is the overuse of globs in %files:

%doc %{_mandir}/man1/%{name}*
%{_datadir}/*
%{_sysconfdir}/*
%{_bindir}/*

1.  MUST: %files need to get a little more specific here, and own only the stuff needed.  I'd suggest:

%files
%doc README
%license LICENSE
%{_mandir}/man1/pacmanager*
%{_datadir}/pacmanager/
%{_datadir}/applications/pacmanager.desktop
%{_datadir}/icons/hicolor/*/apps/pacmanager.*
%{_sysconfdir}/bash_completion.d/pacmanager
%{_bindir}/pacmanager*

that should address most of the important rpmlint issues wrt %files


pkg naming: ok

license: ok

macros: ok

scriptlets: ok

sources: ok
2e27507401adc2d7d9a7631d79a7a45f  pac-4.5.5.7-all.tar.gz


2.  MUST include .desktop file validation, see:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#desktop-file-install_usage

either use desktop-file-install to install it (instead of manual copy), or do a desktop-file-validate in %check section.

3. MUST app icons.  I see one of the icons you use/install is jpg.  that type is not supported for icon themes, see also:
https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#definitions
Either omit that one, or convert it to png.


4.  bash completion files SHOULD go under
/usr/share/bash-completion/completions
ie, 
BuildRequires: pkgconfig(bash-completion)
and install/use the output from
pkg-config --variable=completionsdir bash-completion
(we can fix this collaboratively after review, if this is in anyway unclear)


Please fix the 3 MUST items, and we should have a winner

SPEC diff: https://github.com/xenithorb/pacmanager-spec/commit/92f266138579f580e5444f005758209e9cefb670

SRPM Update: https://copr-be.cloud.fedoraproject.org/results/xenithorb/pacmanager/fedora-24-x86_64/00453000-pacmanager/pacmanager-4.5.5.7-3.fc24.src.rpm

I decided to just remove the offending icon because it had drop shadows already and it was nearly impossible to get it to look good with convert.

non-blocker nit-picks (please fix before submitting any official builds):

5.  .spec update lacked %changelog entry

6.  %files includes:
%{_datadir}/%{name}/*
which still leaves the parent dir unowned, better:
%{_datadir}/%{name}/

7.  consider not using %{name} macro in %files, it's fragile (ie, if the package name ever changed for any reason, the build would fail).


APPROVED.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/pacmanager