Bug 1372343

Summary: hplip-3.16.8-1 has a Python coding bug that prevents one of its filters from working
Product: [Fedora] Fedora Reporter: David H. Gutteridge <dhgutteridge>
Component: hplipAssignee: Zdenek Dohnal <zdohnal>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 24CC: dennis, jpopelka, twaugh, zdohnal
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: hplip-3.16.8-2.fc24 hplip-3.16.8-2.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-05 22:51:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
cupsd log excerpt
none
Patch that fixes the problem none

Description David H. Gutteridge 2016-09-01 13:14:26 UTC 
Description of problem:

hplip-3.16.8-1 has a Python coding bug that prevents one of its filters from working, because tabs and spaces are mixed inconsistently from line to line for the same indentation levels in one code block.

Version-Release number of selected component (if applicable):

hplip-3.16.8-1 

How reproducible:

Always

Steps to Reproduce:
1. Install the updated package.
2. Observe printing from LibreOffice fails on an HP LaserJet 400 M401dne.

Actual results:

Print job ends with an error.

Expected results:

Print job succeeds.

Additional info:

Will be supplied in attachments.
Comment 1 David H. Gutteridge 2016-09-01 13:17:18 UTC 
Created attachment 1196823 [details]
cupsd log excerpt
Comment 2 David H. Gutteridge 2016-09-01 13:20:30 UTC 
Created attachment 1196826 [details]
Patch that fixes the problem

I've tested the attached patch and it resolves the (very trivial) problem. I can print successfully with it. (The file is installed at /usr/lib/cups/filter.)
Comment 3 Zdenek Dohnal 2016-09-01 16:45:54 UTC 
*** Bug 1372405 has been marked as a duplicate of this bug. ***
Comment 4 Zdenek Dohnal 2016-09-01 16:48:26 UTC 
Hi David,

thank you for filling the bug and patch. I rebuild package with this patch.
Comment 5 Fedora Update System 2016-09-01 18:07:37 UTC 
hplip-3.16.8-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c36c1cfe97
Comment 6 Fedora Update System 2016-09-01 18:17:23 UTC 
hplip-3.16.8-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a683b62f49
Comment 7 David H. Gutteridge 2016-09-01 20:15:37 UTC 
hplip-3.16.8-2.fc24 has fixed the problem for me, thanks.
Comment 8 Fedora Update System 2016-09-03 03:23:58 UTC 
hplip-3.16.8-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c36c1cfe97
Comment 9 Fedora Update System 2016-09-03 03:54:29 UTC 
hplip-3.16.8-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a683b62f49
Comment 10 Fedora Update System 2016-09-05 22:51:50 UTC 
hplip-3.16.8-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2016-09-06 18:22:07 UTC 
hplip-3.16.8-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.