Bug 1372591

Summary: Passenger configuration examples incorrect for 6.2
Product: Red Hat Satellite Reporter: Stephen Wadeley <swadeley>
Component: Docs Install GuideAssignee: Julie <juwu>
Status: CLOSED CURRENTRELEASE QA Contact: Stephen Wadeley <swadeley>
Severity: medium Docs Contact:
Priority: high    
Version: 6.2.0CC: adahms, egolov, erinn.looneytriggs, igreen, pdwyer, psuriset
Target Milestone: Unspecified   
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-10-03 08:55:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Stephen Wadeley 2016-09-02 07:44:18 UTC
Document URL: 

https://access.redhat.com/documentation/en/red-hat-satellite/6.2/paged/installation-guide/appendix-a-large-deployment-considerations Increasing Concurrent Content Host

Section Number and Name: 

Increasing Concurrent Content Host Registrations, Step 2

Describe the issue: 

Passenger.conf example incorrect as some changes need to be made for 6.2

Suggestions for improvement: 

docs:
LoadModule passenger_module modules/mod_passenger.so
<IfModule mod_passenger.c>
  PassengerRoot /usr/lib/ruby/gems/1.8/gems/passenger-4.0.18/lib/phusion_passenger/locations.ini
  PassengerRuby /usr/bin/ruby
  PassengerMaxPoolSize 24
  PassengerMaxRequestQueueSize 200
  PassengerStatThrottleRate 120
</IfModule>

really:
<IfModule mod_passenger.c>
   PassengerRoot /usr/share/gems/gems/passenger-4.0.18/lib/phusion_passenger/locations.ini
   PassengerRuby /usr/bin/ruby
+   PassengerMaxPoolSize 24
+   PassengerMaxRequestQueueSize 200
+   PassengerStatThrottleRate 120
</IfModule>


Additional information: 

passenger.conf in 6.2 does not have "loadmodule" anymore, and the passenger root is different

Comment 2 Evgeni Golov 2016-09-02 08:14:36 UTC
passenger.conf
==============

the current version reads like this:

Create the `/etc/httpd/conf.d/passenger.conf` file and insert the following text:

LoadModule passenger_module modules/mod_passenger.so
<IfModule mod_passenger.c>
  PassengerRoot /usr/lib/ruby/gems/1.8/gems/passenger-4.0.18/lib/phusion_passenger/locations.ini
  PassengerRuby /usr/bin/ruby
  PassengerMaxPoolSize 24
  PassengerMaxRequestQueueSize 200
  PassengerStatThrottleRate 120
</IfModule>

* The file is already present, so it should be edited, not created
* The version in 6.2 does not have "LoadModule" anymore
* The version in 6.2 has a differen PassengerRoot

I would suggest rephasing this so that the user knows he/she should *add* PassengerMaxPoolSize, PassengerMaxRequestQueueSize and PassengerStatThrottleRate, not replace the content of the file.
Afterwards the following example can be shown:
<IfModule mod_passenger.c>
   PassengerRoot /usr/share/gems/gems/passenger-4.0.18/lib/phusion_passenger/locations.ini
   PassengerRuby /usr/bin/ruby
   PassengerMaxPoolSize 24
   PassengerMaxRequestQueueSize 200
   PassengerStatThrottleRate 120
</IfModule>


foreman-ssl.conf
================

the current versions reads like this:

Create a Foreman Passenger application configuration file called /etc/httpd/conf.d/05-foreman-ssl.conf file and insert the following text:

PassengerAppRoot /usr/share/foreman
 PassengerRuby /usr/bin/ruby193-ruby
 PassengerMinInstances 6
 PassengerStartTimeout 90
 PassengerMaxPreloaderIdleTime 0
 PassengerMaxRequests 10000
 PassengerPreStart https://example.com

* The file is already present, so it should be edited, not created
* The version in 6.2 has a differen PassengerRuby

I would suggest rephasing this so that the user knows he/she should *add/edit* the various Passenger* limits, not replace the content of the file.
Afterwards the following example can be shown:

  PassengerAppRoot /usr/share/foreman
  PassengerRuby /usr/bin/tfm-ruby
  PassengerMinInstances 6
  PassengerStartTimeout 90
  PassengerMaxPreloaderIdleTime 0
  PassengerMaxRequests 10000
  PassengerPreStart https://example.com


puppet.conf
===========

the current version reads like this:

Create a Puppet Passenger application configuration file called /etc/httpd/conf.d/25-puppet.conf file and insert the following text:

PassengerMinInstances 6
 PassengerStartTimeout 90
 PassengerMaxPreloaderIdleTime 0
 PassengerMaxRequests 10000
 PassengerPreStart https://example.com:8140  /var/lib/pgsql/data/postgresql.conf
 
* The file is already present, so it should be edited, not created
* the " /var/lib/pgsql/data/postgresql.conf" looks like a copy&paste error
* It is not clear where to add the snippet, it should go to at the end of the VirtualHost definition as the changes are not allowed in a <Directory> where the other Passenger option is set.

I would suggest rephasing this so that the user knows he/she should *add* the various Passenger* limits, not replace the content of the file.
Afterwards the following example can be shown:
 PassengerMinInstances 6
 PassengerStartTimeout 90
 PassengerMaxPreloaderIdleTime 0
 PassengerMaxRequests 10000
 PassengerPreStart https://example.com:8140

MISC
====
Also have a loot at the (retired) old guide for 6.1: https://access.redhat.com/articles/1380493
It has some nice explanations what the Passenger* options mean.

Comment 3 Stephen Wadeley 2016-09-05 12:51:40 UTC
Hello

Customer portal member reports:

"the issue is the path to the locations.ini file is incorrect. This one works on RHEL 7.2 Satellite 6.2.1: PassengerRoot /usr/share/gems/gems/passenger-4.0.18/lib/phusion_passenger/locations.ini"

 "recommend raising the issue that the configs are destroyed on upgrade."

That last point could be Docs issue, at least to start with. But we should bring this to the attention of developers responsible for this in case more can be done.

Thank you

Comment 4 Pradeep Kumar Surisetty 2016-09-16 14:44:50 UTC
I made these changes in product documentation. 
please update path in locations.ini. 

Thanks

Comment 5 Andrew Dahms 2016-09-19 05:01:15 UTC
Assigning to Julie for review.

Julie - can you take a look and see how the section stands in comparison to the feedback above?

Comment 8 Ilan Green 2016-09-19 09:45:22 UTC
With respect to comment #3 
"recommend raising the issue that the configs are destroyed on upgrade."

I have raised another bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1377060 related to qpidd max-connections not preserved during upgrade too.

Which might lead to upgrade failures (as far as I understand).

Comment 15 Stephen Wadeley 2016-10-03 08:55:28 UTC
Hello


These changes are now live on the customer portal.

Thank you

https://access.redhat.com/documentation/en/red-hat-satellite/6.2/paged/installation-guide/appendix-a-large-deployment-considerations