Bug 1372621

Summary: [RFE] Add ngx_http_auth_request_module module
Product: [Fedora] Fedora Reporter: Tadej Janež <tadej.j>
Component: nginxAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: athmanem, bperkins, hello, jeremy, jkaluza, pavel.lisy, tim, wtogami
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-15 08:01:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tadej Janež 2016-09-02 08:51:56 UTC
Since nginx gained support for dynamic modules in 1.10, would it be possible to build the ngx_http_auth_request_module (http://nginx.org/en/docs/http/ngx_http_auth_request_module.html) as a dynamic module and provide it as a subpackage?

Comment 1 Tadej Janež 2016-10-17 10:51:52 UTC
(In reply to Tadej Janež from comment #0)
> Since nginx gained support for dynamic modules in 1.10, would it be possible
> to build the ngx_http_auth_request_module
> (http://nginx.org/en/docs/http/ngx_http_auth_request_module.html) as a
> dynamic module and provide it as a subpackage?

I tried building ngx_http_auth_request_module as a dynamic module today and noticed that unfortunately at this moment *only* certain modules can be built as dynamic modules, namely [1][2]:
- ngx_http_geoip_module
- ngx_http_image_filter_module
- ngx_mail_{core, auth, imap, pop3, proxy, smtp, ssl}_module
- ngx_stream_{core, access, limit_conn, proxy, ssl, upstream}_module
- ngx_http_xslt_module
- ngx_http_perl_module

[1] https://www.nginx.com/blog/dynamic-modules-nginx-1-9-11/
[2] http://nginx.org/en/CHANGES-1.10

Therefore, my updated question is, would it be possible to enable building of ngx_http_auth_request_module directly into the nginx?

My patch is here: https://github.com/tjanez/nginx-package/commit/0ed16a4c6ec7bd8886219a284a7882c7dbc3cce6

Comment 2 Tadej Janež 2017-07-14 14:24:00 UTC
Tim Niemueller proposed also enabling ngx_http_auth_request_module for EPEL 6 and 7 versions of nginx in 1471107 and 1471108.

Comment 3 Tim Niemueller 2017-08-15 08:01:39 UTC
Closing as a duplicate of a later independent report because the other one contains a patch. Let's lower the burden on the maintainer by reducing the number of tickets to get to the actual work, hopefully accepting the patch.

*** This bug has been marked as a duplicate of bug 1471106 ***

Comment 4 Tadej Janež 2017-08-17 13:23:36 UTC
(In reply to Tim Niemueller from comment #3)
> Closing as a duplicate of a later independent report because the other one
> contains a patch. Let's lower the burden on the maintainer by reducing the
> number of tickets to get to the actual work, hopefully accepting the patch.

Agreed. Tim's for pushing this!

Comment 5 Tadej Janež 2017-08-17 13:25:07 UTC
(In reply to Tadej Janež from comment #4) 
> Tim's for pushing this!

I wanted to say, Tim thanks for pushing this!