Bug 1373019

Summary:	Review Request: python-fuse - Python module that provides a simple interface to FUSE and MacFUSE
Product:	[Fedora] Fedora	Reporter:	Juan Orti <jorti>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dkrejci, package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-08 18:42:00 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Juan Orti 2016-09-04 19:54:50 UTC

Spec URL: https://jorti.fedorapeople.org/python-fuse/python-fuse.spec
SRPM URL: https://jorti.fedorapeople.org/python-fuse/python-fuse-2.0.4-1.fc24.src.rpm
Description: fusepy is a Python module that provides a simple interface to FUSE and MacFUSE. It's just one file and is implemented using ctypes.
Fedora Account System Username: jorti

Comment 1 Dominika Krejčí 2016-10-14 11:34:37 UTC

Hi Juan, I have some recommendations for you.

* Is there any reason for defining `commit` and `shortcommit` macros? I would be more benefitial to define `srcname` macro for "fuse".

* The `Source0` url should create directory which is named `%{srcname}-%{version}.tar.gz`, not just `%{version}.tar.gz`. (You can just add `#/%{srcname}-%{version}.tar.gz` to your current url.)

* You do not have to rewrite summary manually. Just reuse the first Summary tag with the %{summary} macro.

* "If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it."

Comment 2 Juan Orti 2016-10-17 14:12:44 UTC

Hi, thanks for the comments.

I've updated the macros as you said. I will ask upstream to include a license file.

Spec URL: https://jorti.fedorapeople.org/python-fuse/python-fuse.spec
SRPM URL: https://jorti.fedorapeople.org/python-fuse/python-fuse-2.0.4-2.fc25.src.rpm

Comment 3 Juan Orti 2016-11-03 14:59:49 UTC

This is the request to upstream to include the license text as a saparate file:
https://github.com/terencehonles/fusepy/issues/59

Comment 4 Zbigniew Jędrzejewski-Szmek 2016-11-03 19:09:34 UTC

+ latest version
+ package name is OK
+ license is acceptable (ISC)
+ license is specified correctly
+ standard python packaging template is used
+ %python_provide is present
+ provides/requires look OK
+ no scriptlets present or required

Package is APPROVED.

Comment 5 Juan Orti 2016-11-03 19:13:09 UTC

Thank you. Just tell me if you want me to review one of yours.

Comment 6 Gwyn Ciesla 2016-11-03 21:34:28 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-fuse