Bug 1373199

+++ This bug was initially created as a clone of Bug #828782 (slightly updated) +++

sudo fails to report the error correctly when the execv(3) library call fails. 

Version-Release number of selected component (if applicable): sudo-1.8.17p1-1.fc24.x86_64
sudo-1.8.18b2-1.fc26.x86_64

How reproducible: Always

Steps to Reproduce:

Perform the following steps:
cat <<EOF >script
#!/bin/some_nonexistent_shell
wibble wobble
EOF

chmod +x foo

# An attempt to exec foo will give an error due to a missing interpreter
# ./script; echo $?
-bash: ./script: /bin/some_nonexistent_shell: bad interpreter: No such file or directory
126

# An attempt by sudo to exec foo will give wrong exit code
# sudo ./script; echo $?
sudo: unable to execute ./script: No such file or directory
0

Actual results:
exit code 0

Expected results:
exit code 126 or similar


Additional info:
If I understand the debug messages, I see two (debug) return codes in the end of exectution, but only the second is obviously real return/exit:

Sep  5 14:15:52 sudo[17953] <- main @ ./sudo.c:330 := 129
Sep  5 14:15:52 sudo[17953] <- main @ ./sudo.c:334 := 0

If I see right, the intention was something like this:

diff --git a/src/sudo.c b/src/sudo.c
index 58085e9..c7e771e 100644
--- a/src/sudo.c
+++ b/src/sudo.c
@@ -329,6 +329,7 @@ main(int argc, char *argv[], char *envp[])
 	sudo_debug_exit_int(__func__, __FILE__, __LINE__, sudo_debug_subsys,
 	    WTERMSIG(status) | 128);                
 	kill(getpid(), WTERMSIG(status));
+	exit(WTERMSIG(status) | 128);
     }
     sudo_debug_exit_int(__func__, __FILE__, __LINE__, sudo_debug_subsys,
 	WEXITSTATUS(status));

Testing this specific use case gives me the expected results. Though not sure if it behaves correctly for all the other cases.