Bug 1373438

Summary: EC2 provisioning instance in VPC with EIP error
Product: Red Hat CloudForms Management Engine Reporter: Matouš Mojžíš <mmojzis>
Component: ProvisioningAssignee: Ladislav Smola <lsmola>
Status: CLOSED CURRENTRELEASE QA Contact: Matouš Mojžíš <mmojzis>
Severity: high Docs Contact:
Priority: high    
Version: 5.6.0CC: dajohnso, jhardy, lsmola, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ec2:provision:network
Fixed In Version: 5.7.0.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1376526 1376545 (view as bug list) Environment:
Last Closed: 2017-01-11 19:49:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: AWS Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1376526, 1376545    

Description Matouš Mojžíš 2016-09-06 09:41:48 UTC
Description of problem:


Version-Release number of selected component (if applicable):
5.6.1.2

How reproducible:
Always

Steps to Reproduce:
1. Add an ec2 provider
2. Try to provision ec2 instance in vpc with eip associated
3.

Actual results:
[Aws::EC2::Errors::InvalidParameterCombination]: You must specify an allocation id when mapping an address to a VPC instance 

Expected results:


Additional info:

Comment 2 Matouš Mojžíš 2016-09-06 09:42:29 UTC
Instanced is provisioned, but EIP is not associated.

Comment 7 CFME Bot 2016-09-21 10:47:38 UTC
New commit detected on ManageIQ/manageiq-providers-amazon/master:
https://github.com/ManageIQ/manageiq-providers-amazon/commit/27754e2e176341c1879e3229803098d7eac59e13

commit 27754e2e176341c1879e3229803098d7eac59e13
Author:     Ladislav Smola <lsmola>
AuthorDate: Tue Sep 6 15:14:54 2016 +0200
Commit:     Ladislav Smola <lsmola>
CommitDate: Tue Sep 6 15:18:38 2016 +0200

    VPC floating ip association needs allocation id not ip address
    
    VPC floating ip association needs allocation id not ip address.
    
    Fixes BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1373438
    
    Fixes issue:
    https://github.com/ManageIQ/manageiq/issues/10586

 .../providers/amazon/cloud_manager/provision/configuration.rb      | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comment 8 CFME Bot 2016-09-21 10:47:43 UTC
New commit detected on ManageIQ/manageiq-providers-amazon/master:
https://github.com/ManageIQ/manageiq-providers-amazon/commit/e5595c1a3a9ba774a2ef5e4ff2f1c15abcf4bb84

commit e5595c1a3a9ba774a2ef5e4ff2f1c15abcf4bb84
Author:     Ladislav Smola <lsmola>
AuthorDate: Tue Sep 6 15:16:44 2016 +0200
Commit:     Ladislav Smola <lsmola>
CommitDate: Tue Sep 6 15:18:49 2016 +0200

    For VPC floating Ips allocation id should be ems_ref
    
    For VPC floating Ips allocation id should be the ems_ref, it is
    the unique foreign key used for association.
    
    Fixes BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1373438
    
    Fixes issue:
    https://github.com/ManageIQ/manageiq/issues/10586

 .../manageiq/providers/amazon/network_manager/refresh_parser.rb     | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comment 9 CFME Bot 2016-09-21 13:35:45 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/e9c552b0e0622670b4936c8bbce0374bd44fcb64

commit e9c552b0e0622670b4936c8bbce0374bd44fcb64
Author:     Ladislav Smola <lsmola>
AuthorDate: Tue Sep 6 14:56:08 2016 +0200
Commit:     Ladislav Smola <lsmola>
CommitDate: Tue Sep 6 15:02:15 2016 +0200

    Pass floating ip object to association to deal with special cases
    
    Pass floating ip object to association to deal with special
    cases, e.g. amazon needs to send different info the ip.
    
    Fixes BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1373438
    
    Fixes issue:
    https://github.com/ManageIQ/manageiq/issues/10586

 app/models/manageiq/providers/cloud_manager/provision/state_machine.rb | 2 +-
 .../providers/openstack/cloud_manager/provision/configuration.rb       | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

Comment 10 CFME Bot 2016-11-04 13:41:20 UTC
New commit detected on ManageIQ/manageiq/darga:
https://github.com/ManageIQ/manageiq/commit/5b8430b67f994498bb0f352cb760a0e49d30e347

commit 5b8430b67f994498bb0f352cb760a0e49d30e347
Author:     Ladislav Smola <lsmola>
AuthorDate: Tue Sep 6 14:56:08 2016 +0200
Commit:     Ladislav Smola <lsmola>
CommitDate: Mon Oct 31 09:00:58 2016 +0100

    Pass floating ip object to association to deal with special cases
    
    Pass floating ip object to association to deal with special
    cases, e.g. amazon needs to send different info the ip.
    
    Fixes BZ:
    https://bugzilla.redhat.com/show_bug.cgi?id=1373438
    
    Fixes issue:
    https://github.com/ManageIQ/manageiq/issues/10586

 app/models/manageiq/providers/cloud_manager/provision/state_machine.rb | 2 +-
 .../providers/openstack/cloud_manager/provision/configuration.rb       | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

Comment 11 Matouš Mojžíš 2016-11-10 16:02:41 UTC
Verified in 5.7.0.10. I can provision instance with EIP in VPC and EIP is associated during provision.