Bug 1373623

Summary:	Review Request: glide - Package Management for Golang
Product:	[Fedora] Fedora	Reporter:	Jan Chaloupka <jchaloup>
Component:	Package Review	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	lsm5, package-review
Target Milestone:	---	Keywords:	Reopened
Target Release:	---	Flags:	lsm5: fedora-review+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-27 03:51:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1373551, 1373612
Bug Blocks:

Description Jan Chaloupka 2016-09-06 18:45:36 UTC

Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-Masterminds-glide/golang-github-Masterminds-glide.spec

SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-Masterminds-glide/golang-github-Masterminds-glide-0.12.1-0.1.git8032c28.fc20.src.rpm

Description: Package Management for Golang

Fedora Account System Username: jchaloup

$ rpmlint golang-github-Masterminds-glide-0.12.1-0.1.git8032c28.fc20.src.rpm golang-github-Masterminds-glide-0.12.1-0.1.git8032c28.fc20.x86_64.rpm golang-github-Masterminds-glide-devel-0.12.1-0.1.git8032c28.fc20.noarch.rpm golang-github-Masterminds-glide-unit-test-devel-0.12.1-0.1.git8032c28.fc20.x86_64.rpm golang-github-Masterminds-glide-debuginfo-0.12.1-0.1.git8032c28.fc20.x86_64.rpm
golang-github-Masterminds-glide.x86_64: W: incoherent-version-in-changelog 0-0.1.git8032c28 ['0.12.1-0.1.git8032c28.fc20', '0.12.1-0.1.git8032c28']
golang-github-Masterminds-glide.x86_64: W: no-manual-page-for-binary glide
golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/nv/c/foo.empty
golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/path/a/glide.yaml
golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/path/x/glide.yaml
golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/path/a/b/c/placeholder.empty
golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/nv/b/foo.empty
golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/path/x/y/z/placeholder.empty
golang-github-Masterminds-glide-unit-test-devel.x86_64: W: dangling-relative-symlink /usr/share/gocode/src/github.com/Masterminds/glide/testdata/path/x/vendor symlinked_vendor
golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/nv/a/foo.empty
golang-github-Masterminds-glide-debuginfo.x86_64: E: description-line-too-long C This package provides debug information for package golang-github-Masterminds-glide.
5 packages and 0 specfiles checked; 8 errors, 3 warnings.

Comment 1 Jan Chaloupka 2016-09-06 18:47:18 UTC

There is no Koji build as the package depends on other two which are under review (bz#1373551, bz#1373612). Locally, it builds fine. Testing the glide command locally, vendor directory is created and populated based on content of glide.yaml file.

Comment 2 Lokesh Mandvekar 2016-09-06 19:01:06 UTC

- specfile conforms to current golang packaging draft
- license correct and valid
- only sources installed

approved.

Comment 3 Jan Chaloupka 2016-09-06 19:05:32 UTC

Just renaming the package to glide so it is aligned with the command.

Spec URL: https://jchaloup.fedorapeople.org/reviews/glide/glide.spec

SRPM URL: https://jchaloup.fedorapeople.org/reviews/glide/glide-0.12.1-0.1.git8032c28.fc20.src.rpm

Comment 4 Gwyn Ciesla 2016-09-06 21:51:59 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/glide

Comment 5 Fedora Update System 2016-09-07 12:35:48 UTC

glide-0.12.1-0.1.git8032c28.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-536641196a

Comment 6 Fedora Update System 2016-09-07 12:36:22 UTC

glide-0.12.1-0.1.git8032c28.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-07b77cc878

Comment 7 Fedora Update System 2016-09-07 12:36:41 UTC

glide-0.12.1-0.1.git8032c28.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8536a01d47

Comment 8 Fedora Update System 2016-09-07 12:37:12 UTC

glide-0.12.1-0.1.git8032c28.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f5961c05f6

Comment 9 Fedora Update System 2016-09-09 06:27:35 UTC

glide-0.12.1-0.1.git8032c28.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-07b77cc878

Comment 10 Fedora Update System 2016-09-09 17:18:42 UTC

glide-0.12.1-0.1.git8032c28.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8536a01d47

Comment 11 Fedora Update System 2016-09-09 17:57:49 UTC

glide-0.12.1-0.1.git8032c28.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-536641196a

Comment 12 Fedora Update System 2016-09-12 13:20:01 UTC

glide-0.12.1-0.1.git8032c28.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2016-09-12 15:29:25 UTC

glide-0.12.1-0.1.git8032c28.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f5961c05f6

Comment 14 Fedora Update System 2016-09-27 03:51:09 UTC

glide-0.12.1-0.1.git8032c28.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.