Bug 1373916

Summary: RHV VM Reconfigure: Remove disks section, in case of no storage associated with the VM or api version is not supported
Product: Red Hat CloudForms Management Engine Reporter: Ilanit Stein <istein>
Component: ProvidersAssignee: Moti Asayag <masayag>
Status: CLOSED CURRENTRELEASE QA Contact: Ilanit Stein <istein>
Severity: high Docs Contact:
Priority: unspecified    
Version: 5.7.0CC: cpelland, jfrey, jhardy, lcouzens, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: rhev
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1391711 (view as bug list) Environment:
Last Closed: 2017-06-12 17:04:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1391711    

Description Ilanit Stein 2016-09-07 12:23:35 UTC 
Description of problem:
Currently it is possible to run a request for 
adding a 1st bootable disk, to a VM, and it fails with error: 
"undefined method `store_type' for nil:NilClass" 

Please remove the Disks section, in VM Reconfigure window, in case of no storage is associated with the VM.

Version-Release number of selected component (if applicable):
RHV-4.0.3
manageiq-ovirt-master-201609022000-30b49facaf.ova
Comment 2 Moti Asayag 2016-09-08 05:11:21 UTC 
The is an additional case in which the 'Disks' section should be hidden for RHV vms: when the provider's api version doesn't support v4.
Comment 3 Moti Asayag 2016-10-15 14:05:46 UTC 
*** Bug 1384474 has been marked as a duplicate of this bug. ***
Comment 4 Moti Asayag 2016-10-15 18:20:29 UTC 
https://github.com/ManageIQ/manageiq/pull/11971
Comment 6 Ilanit Stein 2017-04-26 13:16:14 UTC 
Verified on CFME-5.8.0.12
Works as expected:

For RHV-4.1.1.8, VM that had no disks attached, had no VM reconfigure->Disks section 
For RHV-4.1.1.8, VM that disks attached, there was a VM reconfigure->Disks section
For RHV-3.6.8, down VM, that have disks, had no VM reconfigure->Disks section