Bug 1373954

Summary:	rpm: next_brace_sub() OOB read segfaults when given malformed brace'd expressions
Product:	[Other] Security Response	Reporter:	Cedric Buissart <cbuissar>
Component:	vulnerability	Assignee:	Red Hat Product Security <security-response-team>
Status:	CLOSED NOTABUG	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	unspecified	CC:	ffesti, kardos.lubos, novyjindrich, packaging-team-maint, pknirsch
Target Milestone:	---	Keywords:	Security
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-07 14:52:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	1373956
Bug Blocks:	1357448

Description Cedric Buissart 2016-09-07 14:14:30 UTC

A malformed expression with braces can lead to a heap out-of-bound read in next_brace_sub(), causing a segfault.

The flaw has been enabled when brace'd expansion has been enabled, via the following upstream commit (present in rpm-4.13.0-rc1):
https://github.com/rpm-software-management/rpm/commit/d14ecfe587

The flaw was fixed by the following subsequent commit :
https://github.com/rpm-software-management/rpm/commit/1af568ac


Backtrace :
#0  next_brace_sub () at rpmglob.c:129
#1  rpmIsGlob () at rpmglob.c:991
#2  0x00007ffff7952929 in rpmGlob () at rpmglob.c:879
#3  0x00007ffff7b98670 in rpmReadPackageManifest () at manifest.c:117
#4  0x00007ffff7ba8a63 in rpmgiLoadManifest () at rpmgi.c:76
#5  rpmgiLoadReadHeader () at rpmgi.c:152
#6  rpmgiNext () at rpmgi.c:238
#7  0x00007ffff7b9d579 in rpmgiShowMatches () at query.c:273
#8  rpmcliArgIter () at query.c:545
#9  0x00007ffff7b9d660 in rpmcliQuery () at query.c:602
#10 0x0000555555555959 in main ()

Comment 1 Cedric Buissart 2016-09-07 14:14:43 UTC

Acknowledgments:

Name: Francisco Alonso

Comment 2 Cedric Buissart 2016-09-07 14:16:28 UTC

Created rpm tracking bugs for this issue:

Affects: fedora-all [bug 1373956]