| Summary: | It's better to disable the create button on create app from image page when env or label name is empty | ||||||
|---|---|---|---|---|---|---|---|
| Product: | OKD | Reporter: | Yadan Pei <yapei> | ||||
| Component: | Management Console | Assignee: | bpeterse | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Yadan Pei <yapei> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 3.x | CC: | aos-bugs, jforrest, mmccomas, yanpzhan | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-12-09 21:50:35 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Yadan Pei
2016-09-08 06:23:57 UTC
PR open to address this issue: https://github.com/openshift/origin-web-console/pull/584 PR merged into origin-web-console, not yet vendored back to origin. After tested against the pr, found that there will be error showing "Key is required" if set env/label's value but key is empty, and the "Create" button is disabled. Then remove the env/label's value, the error is still there with "Create" button disabled. Pls refer to the attachment. This should be fixed. Created attachment 1204708 [details]
errorinfo.png
Looking into this At present, here is the behavior: - pressing the "x" control to trigger the clear row fn will eliminate the warning - pressing the "delete" key to delete the values will eliminate the warning - using ctrl + x to "cut" the value will not eliminate the warning. This does not trigger the keyup event (oddly) PR to the underlying editor: https://github.com/openshift/angular-key-value-editor/pull/117 will PR the web console once that merges. Checked against v3.4.0.18+ada983f 1. Type only env/label value, error info will prompt "Key is required" and Create button is disabled 2. Using ctrl + x to cut the env/label value, the error will not be eliminated, and Create button still disabled 3. Clear value using backspace, the error will not be eliminated, and Create button still disabled 4. Clicking "x" control will eliminate the warning and Create button got enabled Move to VERIFIED |