Bug 1374194

Summary: [OVS] - Allow to configure also a prefix for a network static ip
Product: [oVirt] ovirt-engine Reporter: Michael Burman <mburman>
Component: BLL.NetworkAssignee: Petr Horáček <phoracek>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.1.0CC: bugs, danken, mburman, ylavi
Target Milestone: ovirt-4.0.6Flags: danken: ovirt-4.0.z?
mburman: planning_ack?
rule-engine: devel_ack+
rule-engine: testing_ack+
Target Release: 4.0.6   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-01-18 07:25:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
supervdsm log none

Description Michael Burman 2016-09-08 08:44:37 UTC
Description of problem:
[OVS] - Allow to configure also a prefix for a network static ip.

Currently we are not allowing to configure a prefix for ovs network static ip, only netmask. 

jsonrpc/7::ERROR::2016-09-08 10:42:53,396::API::1518::vds::(setupNetworks) Must specify netmask to configure ip for network.
Traceback (most recent call last):
  File "/usr/share/vdsm/API.py", line 1515, in setupNetworks
    supervdsm.getProxy().setupNetworks(networks, bondings, options)
  File "/usr/lib/python2.7/site-packages/vdsm/supervdsm.py", line 53, in __call__
    return callMethod()
  File "/usr/lib/python2.7/site-packages/vdsm/supervdsm.py", line 51, in <lambda>
    **kwargs)
  File "<string>", line 2, in setupNetworks
  File "/usr/lib64/python2.7/multiprocessing/managers.py", line 773, in _callmethod
    raise convert_to_error(kind, result)
ConfigNetworkError: (22, 'Must specify netmask to configure ip for network.')

Version-Release number of selected component (if applicable):
4.1.0-0.0.master.20160907231315.gitfa04f87.el7.centos

How reproducible:
100

Steps to Reproduce:
1. Add host to OVS type cluster(4.1) 
2. Attach network to host via setup networks dialog and set a static ip with prefix 24

Actual results:
Error while executing action HostSetupNetworks: Illegal or Incomplete IP Address
- When setting netmask it works

Expected results:
Netmask and prefix are allowed(like on legacy type)

Comment 1 Dan Kenigsberg 2016-09-08 10:19:00 UTC
please add supervdsm.log, including the setupNetworks() call.

Comment 2 Michael Burman 2016-09-08 10:50:29 UTC
Created attachment 1198994 [details]
supervdsm log

Comment 3 Dan Kenigsberg 2016-09-08 12:16:46 UTC
Could you pinpoint me to the log line with setupNetworks command that is lacking prefix (what is the network name)? I fail to find it in the logs.

Comment 4 Michael Burman 2016-09-08 12:34:49 UTC
MainProcess|jsonrpc/7::DEBUG::2016-09-08 13:47:39,354::api::247::root::(setupNetworks) Setting up network according to configuration: networks:{'ovs-net1': {'ipv6autoconf': True, 'nic': 'enp6s0', 'ipaddr': '5.5.5.5', 'prefix': '24', 'mtu': 1500, 'switch': 'ovs', 'dhcpv6': False, 'STP': 'no', 'bridged': 'true'}}, bondings:{}, options:{'connectivityCheck': 'true', 'connectivityTimeout': 120}
MainProcess|jsonrpc/7::DEBUG::2016-09-08 13:47:39,354::api::268::root::(_setup_networks) Validating configuration


MainProcess|jsonrpc/7::INFO::2016-09-08 13:47:40,475::netconfpersistence::58::root::(setNetwork) Adding network ovs-net1({'ipv6autoconf': True, 'nameservers': [], 'nic': 'enp6s0', 'ipaddr': '5.5.5.5', 'switch': 'ovs', 'mtu': 1500, 'prefix': '24', 'dhcpv6': False, 'stp': False, 'bridged': True, 'defaultRoute': False}


It's not lacking prefix, it is sent, but failing.
Network name is 'ovs-net1'

Comment 5 Red Hat Bugzilla Rules Engine 2016-09-08 18:27:34 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 6 Michael Burman 2016-11-20 13:49:43 UTC
Verified on - vdsm-4.18.16-1.el7ev.x86_64 and 4.0.6-0.1.el7ev