Bug 1374398

Summary: SSUI displays "null" for azure resource group or fails if <new resource group> is selected
Product: Red Hat CloudForms Management Engine Reporter: Josh Carter <jocarter>
Component: UI - OPSAssignee: Bill Wei <bilwei>
Status: CLOSED CURRENTRELEASE QA Contact: Shveta <sshveta>
Severity: high Docs Contact:
Priority: high    
Version: 5.6.0CC: benglish, bilwei, cpelland, dclarizi, eclarizi, gmccullo, hkataria, jhardy, jocarter, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.7.0   
Hardware: All   
OS: All   
Whiteboard: ssui
Fixed In Version: 5.7.0.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1375205 (view as bug list) Environment:
Last Closed: 2017-01-11 20:03:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1375205    
Attachments:
Description Flags
hotfix attachment
none
SSUI Default Value Hotfix
none
Stack failure reason none

Comment 4 Greg McCullough 2016-09-08 19:52:51 UTC
Bill - Please review this issue and see if it is a SSUI or backend.  It could be a little of both and we'll need to get erik involved.

Comment 6 Bill Wei 2016-09-09 19:28:15 UTC
Created attachment 1199594 [details]
hotfix attachment

Please try this hotfix. It solves the problem that new_resource_group does not get created.

Comment 7 CFME Bot 2016-09-09 20:30:54 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/703cdeab445da86857bf8ff740deec90d6ef89a6

commit 703cdeab445da86857bf8ff740deec90d6ef89a6
Author:     Bill Wei <bilwei>
AuthorDate: Thu Sep 8 18:00:28 2016 -0400
Commit:     Bill Wei <bilwei>
CommitDate: Fri Sep 9 15:43:10 2016 -0400

    Take new_resource_group when resource_group is blank
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1374398

 .../orchestration_service_option_converter.rb       |  2 +-
 .../orchestration_service_option_converter_spec.rb  | 21 +++++++++++++++++++++
 2 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 spec/models/manageiq/providers/azure/cloud_manager/orchestration_stack/orchestration_service_option_converter_spec.rb

Comment 16 eclarizi 2016-09-13 22:43:08 UTC
Created attachment 1200653 [details]
SSUI Default Value Hotfix

Comment 17 eclarizi 2016-09-13 22:43:54 UTC
Hotfix created from all non-spec files of this PR: https://github.com/ManageIQ/manageiq-ui-self_service/pull/130

Comment 22 CFME Bot 2016-09-15 14:27:42 UTC
New commit detected on ManageIQ/manageiq-ui-self_service/master:
https://github.com/ManageIQ/manageiq-ui-self_service/commit/1aa14ce0d29e15a72855e2fb9531678c817dd374

commit 1aa14ce0d29e15a72855e2fb9531678c817dd374
Author:     Erik Clarizio <eclarizi>
AuthorDate: Tue Sep 13 13:14:10 2016 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Wed Sep 14 09:02:06 2016 -0700

    Select first item in drop down list by default if no default value given
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1374398
    
    Or, if the default value is "null", it will still select the first value
    instead of selecting nothing. This way we should always get something
    passed in, even if the first actual value's key is *supposed* to be
    "null"

 .../components/dialog-content/dialog-content.html  |  7 +---
 .../app/services/dialog-field-refresh.service.js   | 41 +++++++++---------
 tests/dialog-field-refresh.service.spec.js         | 48 ++++++++++++++++------
 3 files changed, 58 insertions(+), 38 deletions(-)

Comment 29 Shveta 2016-10-11 19:57:14 UTC
Created a request in SSUI for Azure.
Gave the new-resource group name and left the "existing resource group" blank.
Stack was not created under new resource group.

Please check https://10.8.199.117/self_service

Comment 30 Bill Wei 2016-10-12 20:18:21 UTC
Created attachment 1209766 [details]
Stack failure reason

You have actually verified the fix. The stack has been created but the status was failure.
The log shows

[----] I, [2016-10-11T15:33:06.732311 #11699:ba3c54]  INFO -- : Q-task_id([service_template_provision_task_2]) <AutomationEngine> <AEMethod check_provisioned> Stack deployment 
finished. Status: error, reason: Stack creation failed
[----] I, [2016-10-11T15:33:06.733876 #11699:ba3c54]  INFO -- : Q-task_id([service_template_provision_task_2]) <AutomationEngine> <AEMethod check_provisioned> Please examine stack resources for more details

If you browse the stack testazstack and drill down to its resources you can see the actual failure reason was the invalid password. See the screenshot.

Comment 31 Shveta 2016-10-12 20:20:17 UTC
Verified in 5.7.0.4-alpha1.20161005153002_cfc8a23