Bug 1374446
| Summary: | Prevent some double spaces in ip route output | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Phil Sutter <psutter> |
| Component: | iproute | Assignee: | Timothy Redaelli <tredaelli> |
| Status: | CLOSED ERRATA | QA Contact: | Jaroslav Aster <jaster> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 7.4 | CC: | atragler, jaster, tredaelli |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | iproute-3.10.0-82.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-01 21:32:13 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Backported commit 7cc7cb8a888bf50c4e118b6bce4c6926321d0689 Unfortunately, it is not fixed. There are still two spaces before features option. Switching to assigned state. # ip route add 172.29.29.0/24 dev eth0 table 1234 # ip route change 172.29.29.0/24 dev eth0 features ecn table 1234 # ip route show table 1234 | grep 172.29.29.0/24 | grep ' features' 172.29.29.0/24 dev eth0 scope link features ecn Hi Jaroslav, (In reply to Jaroslav Aster from comment #4) > Unfortunately, it is not fixed. There are still two spaces before features > option. Switching to assigned state. > > # ip route add 172.29.29.0/24 dev eth0 table 1234 > # ip route change 172.29.29.0/24 dev eth0 features ecn table 1234 > # ip route show table 1234 | grep 172.29.29.0/24 | grep ' features' > 172.29.29.0/24 dev eth0 scope link features ecn Strictly speaking, this is a different issue. The problems this ticket addressed (namely, fix *some* double spaces in output) are fixed as expected. Yet Timothy is currently preparing a fix for upstream and if it gets accepted I'll kindly pull it in in order to get rid of the remaining issues of this type in ip route output. Anyway, thanks a lot for having a close look. Iproute output is constantly broken, so I'm aware this is not the most rewarded job out there. :) Thanks, Phil Hi Phil, disagree :-), I have test for that => it is what I have reported to you. Anyway, do your best, it doesn't have hight priority. Hi Jaroslav, (In reply to Jaroslav Aster from comment #6) > disagree :-), I have test for that => it is what I have reported to you. Oh, OK! :) > Anyway, do your best, it doesn't have hight priority. I have backported Tim's fix: commit 5551ed44d394fac6e9a035dadb259580fbda84d3 Author: Timothy Redaelli <tredaelli> Date: Wed Apr 5 19:10:26 2017 +0200 ip-route: Prevent some other double spaces in output Print spaces only after text. CC: Phil Sutter <phil> Signed-off-by: Timothy Redaelli <tredaelli> Acked-by: Phil Sutter <phil> Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:2171 |
Backport the following fix from upstream: commit 7cc7cb8a888bf50c4e118b6bce4c6926321d0689 Author: Phil Sutter <phil> Date: Tue Aug 23 11:52:45 2016 +0200 ip-route: Prevent some double spaces in output The code is a bit messy, as it starts with space after text and at some point switches to space before text. But either way, printing space before *and* after text almost certainly leads to printing more whitespace than necessary. Signed-off-by: Phil Sutter <phil>