Bug 1374627

Summary:	Worker crashes with EINVAL errors
Product:	[Community] GlusterFS	Reporter:	Aravinda VK <avishwan>
Component:	geo-replication	Assignee:	Aravinda VK <avishwan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.5	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1373373	Environment:
Last Closed:	2016-10-20 14:02:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1373373
Bug Blocks:

Description Aravinda VK 2016-09-09 09:04:47 UTC

+++ This bug was initially created as a clone of Bug #1373373 +++

Description of problem:
During Hybrid crawl if the files are unlinked then worker crashes with EINVAL error.

Steps to Reproduce:
1. Create Master Volume and generate data
2. Create Slave Volume and establish Geo-rep session and start(Starts with Hybrid Crawl for initial sync)
3. Once started wait for 2-5 seconds and delete files.

Actual results:
Worker crashes with EINVAL traceback

Expected results:
Workers should not crash

--- Additional comment from Worker Ant on 2016-09-06 02:40:28 EDT ---

REVIEW: http://review.gluster.org/15404 (geo-rep: Fix ESTALE/EINVAL issue during set_{xtime,stime}) posted (#1) for review on master by Aravinda VK (avishwan)

--- Additional comment from Worker Ant on 2016-09-08 12:15:45 EDT ---

COMMIT: http://review.gluster.org/15404 committed in master by Aravinda VK (avishwan) 
------
commit 9db2826cd8dbcc0fb58f5434c21d00ca5c15c491
Author: Aravinda VK <avishwan>
Date:   Tue Sep 6 12:02:02 2016 +0530

    geo-rep: Fix ESTALE/EINVAL issue during set_{xtime,stime}
    
    Setfattr may get ESTALE/EINVAL if a file is being unlinked.
    To prevent worker crashing, added retry for these error messages.
    
    On second retry it will get ENOENT and that error is handled by
    ignoring.
    
    BUG: 1373373
    Change-Id: Ic660fa13208366d57c8d3d492bbef611475e45b7
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/15404
    Reviewed-by: Saravanakumar Arumugam <sarumuga>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Kotresh HR <khiremat>
    Smoke: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2016-09-09 09:53:15 UTC

REVIEW: http://review.gluster.org/15452 (geo-rep: Fix ESTALE/EINVAL issue during set_{xtime,stime}) posted (#1) for review on release-3.8 by Aravinda VK (avishwan)

Comment 2 Niels de Vos 2016-09-12 05:37:37 UTC

All 3.8.x bugs are now reported against version 3.8 (without .x). For more information, see http://www.gluster.org/pipermail/gluster-devel/2016-September/050859.html

Comment 3 Worker Ant 2016-09-15 06:30:23 UTC

COMMIT: http://review.gluster.org/15452 committed in release-3.8 by Aravinda VK (avishwan) 
------
commit ed7d5042b68d1f25cc6c957ad9a0d82b1090fad0
Author: Aravinda VK <avishwan>
Date:   Tue Sep 6 12:02:02 2016 +0530

    geo-rep: Fix ESTALE/EINVAL issue during set_{xtime,stime}
    
    Setfattr may get ESTALE/EINVAL if a file is being unlinked.
    To prevent worker crashing, added retry for these error messages.
    
    On second retry it will get ENOENT and that error is handled by
    ignoring.
    
    > Reviewed-on: http://review.gluster.org/15404
    > Reviewed-by: Saravanakumar Arumugam <sarumuga>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Kotresh HR <khiremat>
    > Smoke: Gluster Build System <jenkins.org>
    
    BUG: 1374627
    Change-Id: Ic660fa13208366d57c8d3d492bbef611475e45b7
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/15452
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Saravanakumar Arumugam <sarumuga>

Comment 4 Niels de Vos 2016-10-20 14:02:35 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.5, please open a new bug report.

glusterfs-3.8.5 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/announce/2016-October/000061.html
[2] https://www.gluster.org/pipermail/gluster-users/