Bug 1374767

Summary: chrony-helper should escape domain for SRV records
Product: [Fedora] Fedora Reporter: Tomasz Torcz <tomek>
Component: chronyAssignee: Miroslav Lichvar <mlichvar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mlichvar
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: chrony-2.4-3.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1418968 (view as bug list) Environment:
Last Closed: 2016-09-17 00:57:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tomasz Torcz 2016-09-09 14:56:23 UTC
Description of problem:
'chrony-helper enable-dnssrv _ntp._udp.DOMAIN' enables instance of a timer 'chrony-dnssrv'. systemd requires for '-' character to be escaped in unit names. (There are few more escaping rules, but for characters which are not used in domain names).

Therefore lines like this:
#v+
set_dnssrv_timer() {
…
    local timer=$dnssrv_timer_prefix$name.timer
#v-

have to be written as

    local timer=$dnssrv_timer_prefix$(systemd-escape $name).timer

'systemd-escape' is a helper program, part of systemd suite.

Version-Release number of selected component (if applicable):
chrony-2.4-2.fc25.x86_64

Comment 1 Miroslav Lichvar 2016-09-13 08:44:39 UTC
This should be now fixed in chrony-2.4-3.fc26. Thanks.

Comment 2 Fedora Update System 2016-09-13 09:10:08 UTC
chrony-2.4-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0fd0996cac

Comment 3 Fedora Update System 2016-09-14 03:25:09 UTC
chrony-2.4-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0fd0996cac

Comment 4 Fedora Update System 2016-09-17 00:57:56 UTC
chrony-2.4-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.