| Summary: | Toolbars: allow passing additional html attributes to button <a> tags. | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | John Prause <jprause> | |
| Component: | UI - OPS | Assignee: | Martin Povolny <mpovolny> | |
| Status: | CLOSED NOTABUG | QA Contact: | Matouš Mojžíš <mmojzis> | |
| Severity: | unspecified | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 5.6.0 | CC: | dajohnso, hkataria, jhardy, mmojzis, mpovolny, obarenbo, simaishi | |
| Target Milestone: | GA | Keywords: | ZStream | |
| Target Release: | 5.7.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ui | |||
| Fixed In Version: | 5.7.0.0 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1375614 (view as bug list) | Environment: | ||
| Last Closed: | 2016-09-29 20:08:50 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | Unknown | Target Upstream Version: | ||
| Bug Depends On: | ||||
| Bug Blocks: | 1375614 | |||
|
Description
John Prause
2016-09-09 18:34:26 UTC
Merged and darga/backported: https://github.com/ManageIQ/manageiq/pull/8079 ----- Original Message -----
> From: "Martin Povolny" <mpovolny>
> To: "Dave Johnson" <dajohnso>
> Cc: "Matous Mojzis" <mmojzis>, "Milan Falešník" <mfalesni>
> Sent: Thursday, September 29, 2016 2:38:00 PM
> Subject: Re: Skipping a BZ
>
> Hi.
>
> As I already wrote I have no idea how you want to test this and what would
> be the benefit of that.
>
> The change was to support some toolbar feature that the container team
> needed for another feature.
>
> The feature was not used so it had no effect. It's an internal thing.
>
> Meanwhile the toolbars where rewritten and the feature in question has no
> longer any sense.
>
> The PR that used the feature (make sure you have test coverage for that if
> you want this all to have any value):
> https://github.com/ManageIQ/manageiq/pull/9465
>
> On Thu, Sep 29, 2016 at 6:42 PM, Dave Johnson <dajohnso> wrote:
>
> > Martin, can you help us out here? We are not sure how to verify. From BZ
> > comment...
> >
> > Matouš Mojžíš 2016-09-20 11:12:40 EDT
> > What shall I verify?
> > That there is in <a> tag ng-click= attribute?
> > Or what?
> >
> > Thanks,
> > -Dave
|