Bug 1374987

Summary: Shift+F1 does not display help in byobu
Product: [Fedora] Fedora EPEL Reporter: Masafumi Miura <mmiura>
Component: byobuAssignee: Priscila Gutierres <prgutier>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: epel7CC: jan.klepek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-25 21:36:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
byobu-help-proposed-patch.diff none

Description Masafumi Miura 2016-09-11 12:28:55 UTC
Created attachment 1199882 [details]
byobu-help-proposed-patch.diff

Description of problem:

Shift+F1 does not display help in byobu. 


Version-Release number of selected component (if applicable):

byobu-5.73-4.el7.noarch


How reproducible:

Anytime.


Steps to Reproduce:
1. Start byobu
2. Hit "Shift+F1" to show help


Actual results:

help is not displayed. (nothing happens.)


Expected results:

help is displayed.


Additional info:

help.{screen,tmux}.txt actually exist under /usr/share/doc/byobu-5.73/. But /usr/share/byobu/keybindings/f-keys.screen and /usr/share/byobu/keybindings/f-keys.tmux point to /usr/share/doc/byobu/. 

So, here's a proposed patch:

~~~
--- a/f-keys.screen
+++ b/f-keys.screen
@@ -27,7 +27,7 @@ register x "^^"						#     | Goes with the F12 definition
 # F-keys seem to work well in both gnome-terminal and tty consoles
 bindkey -k k1 $BYOBU_BACKEND -t config 0 byobu-config	# F1  | Configuration (along with F9)
 							#     | since F1 = Help in gnome-terminal
-bindkey "^[O1;2P" $BYOBU_BACKEND -t help 0 $BYOBU_PAGER $BYOBU_PREFIX/share/doc/byobu/help.screen.txt	# shift-F1  | help
+bindkey "^[O1;2P" $BYOBU_BACKEND -t help 0 $BYOBU_PAGER $BYOBU_PREFIX/share/doc/byobu-5.73/help.screen.txt	# shift-F1  | help
 bindkey -k k2 $BYOBU_BACKEND				# F2  | Create new window
 bindkey "^[O1;5Q" eval 'split -v' 'focus down' 'next' 'focus up' 'layout save byobu' 'layout autosave' 'screen'	# ctrl-F2  | vertical split
 bindkey "^[O1;2Q" eval 'split' 'focus down' 'next' 'focus up' 'layout save byobu' 'layout autosave' 'screen'	# shift-F2 | horizontal split

--- a/f-keys.tmux
+++ b/f-keys.tmux
@@ -25,9 +25,9 @@ set -g prefix F12
 source $BYOBU_PREFIX/share/byobu/keybindings/f-keys.tmux.disable
 
 # Byobu's Keybindings
-# Documented in: $BYOBU_PREFIX/share/doc/byobu/help.tmux.txt
+# Documented in: $BYOBU_PREFIX/share/doc/byobu-5.73/help.tmux.txt
 bind-key -n F1 new-window -k -n config byobu-config
-bind-key -n S-F1 new-window -k -n help '$BYOBU_PAGER $BYOBU_PREFIX/share/doc/byobu/help.tmux.txt'
+bind-key -n S-F1 new-window -k -n help '$BYOBU_PAGER $BYOBU_PREFIX/share/doc/byobu-5.73/help.tmux.txt'
 bind-key -n F2 new-window \; rename-window "-"
 bind-key -n C-F2 display-panes \; split-window -h
 bind-key -n S-F2 display-panes \; split-window -v
~~~

Comment 1 Fedora Admin user for bugzilla script actions 2023-11-19 00:10:46 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 2 Fedora Admin user for bugzilla script actions 2023-11-22 12:08:56 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 4 Priscila Gutierres 2023-11-25 21:38:05 UTC
This bug has been already fixed on byobu-5.133-9.fc38.src.rpm.