Bug 1375098

REVIEW: http://review.gluster.org/15467 (dht: "replica.split-brain-status" attribute value is not correct) posted (#1) for review on release-3.8 by MOHIT AGRAWAL (moagrawa)

REVIEW: http://review.gluster.org/15467 (dht: "replica.split-brain-status" attribute value is not correct) posted (#2) for review on release-3.8 by MOHIT AGRAWAL (moagrawa)

COMMIT: http://review.gluster.org/15467 committed in release-3.8 by Raghavendra G (rgowdapp) 
------
commit a0e38b6e0ab67941d9405d4a12d63096bdb1b7a4
Author: Mohit Agrawal <moagrawa>
Date:   Fri Aug 19 10:33:50 2016 +0530

    dht: "replica.split-brain-status" attribute value is not correct
    
    Problem: In a distributed-replicate volume attribute
             "replica.split-brain-status" value does not display split-brain
               condition though directory is in split-brain.
             If directory is in split brain on mutiple replica-pairs
             it does not show full list of replica pairs.
    
    Solution: Update the dht_aggregate code to aggregate the xattr
              value in this specific condition.
    
    Fix:      1) function getChoices returns the choices from split-brain
                 status string.
              2) function add_opt adding the choices to local buffer to
                 store in dictionary
              3) For the key "replica.split-brain-status" function dht_aggregate
                 call dht_aggregate_split_brain_xattr to prepare the list.
    
    Test:     To verify the patch followed below steps
              1) Create a distributed replica volume and create mount point
              2) Stop heal daemon
              3) Touch file and directories on mount point
                 mkdir test{1..5};touch tmp{1..5}
              4) Down brick process on one of the replica set
                 pkill -9 glusterfsd
              5) Change permission of dir on mount point
                 chmod 755 test{1..5}
              6) Restart brick process on node with force option
              7) kill brick process on other node in same replica set
              8) Change permission of dir again on mount point
                 chmod 766 test{1..5}
              9) Reexecute same step from 4-9 on other replica set also
              10) After check heal status on server it will show dir's are
                  in split brain on all replica sets
              11) After check the replica.split-brain-status attr on mount
                  point it will show wrong status of split brain.
              12) After apply the patch the attribute shows correct value.
    
    > Change-Id: Icdfd72005a4aa82337c342762775a3d1761bbe4a
    > Signed-off-by: Mohit Agrawal <moagrawa>
    > Reviewed-on: http://review.gluster.org/15201
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Raghavendra G <rgowdapp>
    > (cherry picked from commit c4e9ec653c946002ab6d4c71ee8e6df056438a04)
    
    Change-Id: I85a5ae60189066d9e80799f00f1352c2f33ef4f8
    Backport of commit c4e9ec653c946002ab6d4c71ee8e6df056438a04
    BUG: 1375098
    Signed-off-by: Mohit Agrawal <moagrawa>
    Reviewed-on: http://review.gluster.org/15467
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.5, please open a new bug report.

glusterfs-3.8.5 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/announce/2016-October/000061.html
[2] https://www.gluster.org/pipermail/gluster-users/