Bug 1375244

Summary:	Rebase to sync sbd with upstream & rhel 7
Product:	Red Hat Enterprise Linux 6	Reporter:	Klaus Wenninger <kwenning>
Component:	sbd	Assignee:	Klaus Wenninger <kwenning>
Status:	CLOSED ERRATA	QA Contact:	Jaroslav Kortus <jkortus>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.9	CC:	cfeist, jkortus, kgaillot, mnovacek, royoung
Target Milestone:	rc	Keywords:	Rebase
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	sbd-1.2.1-31.el6	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-21 10:38:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Klaus Wenninger 2016-09-12 14:17:55 UTC

Description of problem:

SBD is not a super active upstream project but recently there had been
a couple of interesting changes that interfere with a lot of files
like stuff for pacemaker-remote and clarification of licensing in
most of the files.
So it is much cleaner and easier to support to base on the 
upstream version and patch what we want differently (like e.g. not
supporting block-devices for now) instead of doing it the other
way round.

Comment 2 Klaus Wenninger 2016-09-12 14:42:54 UTC

talking of not having sbd_helper?
If yes we should talk about that again ...

Comment 3 Jaroslav Kortus 2016-09-12 16:18:59 UTC

exactly, and perhaps stripping the patched-out features from man page and help or just blindly replace them with a note that it's not something they should use and it's only a heavily modifed "subcomponent" of original SBD :)

Comment 5 Klaus Wenninger 2016-11-07 15:33:03 UTC

jkortus: What about something like that: http://file.muc.redhat.com/~kwenning/sbd/sbd.html

man2html seems to screw newline-handling a bit - with man as manpage-reader it seems to be OK where the options are listed

Comment 6 Klaus Wenninger 2016-11-07 15:49:15 UTC

ad last comment) have added Andrew to the copyright-section of the manpage starting with his first commit to the sbd-github-repo ...

Comment 7 Jaroslav Kortus 2016-12-12 13:00:37 UTC

The man page looks great and compared to the original is much more accurate and actually helpful :).

Thank you.

Comment 8 Klaus Wenninger 2016-12-12 13:05:17 UTC

You're welcome ;-)

Comment 9 michal novacek 2017-02-13 14:37:30 UTC

Our internal tests shows that the rebased sbd-1.2.1-31 is in good condition.

Marking verified.

Comment 11 errata-xmlrpc 2017-03-21 10:38:30 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0681.html