Bug 1375275
Summary: | oc process "FOO=a=b" error "invalid parameter assignment" if value contains the equal sign | ||||||
---|---|---|---|---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Marek Schmidt <maschmid> | ||||
Component: | oc | Assignee: | Ben Parees <bparees> | ||||
Status: | CLOSED ERRATA | QA Contact: | Xingxing Xia <xxia> | ||||
Severity: | high | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 3.3.0 | CC: | aos-bugs, bleanhar, bparees, jokerman, mmccomas, pruan, tdawson, yapei | ||||
Target Milestone: | --- | Keywords: | Regression | ||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: |
Cause:
Improper argument parsing rejected valid values.
Consequence:
Parameter values containing equal signs were incorrectly rejected.
Fix:
Change parsing to tolerate values containing equal signs.
Result:
Parameter values containing equal signs are tolerated.
|
Story Points: | --- | ||||
Clone Of: | Environment: | ||||||
Last Closed: | 2016-09-27 09:47:28 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Marek Schmidt
2016-09-12 15:12:07 UTC
Seems related to https://github.com/openshift/origin/commit/6eaf7a2690b72c352b417c62209911e462b96b9c Checked on devenv-rhel7_5003 (openshift v1.3.0-rc1+3cd9a1f). Fixed. Multi '='s work well. Wait for merge into OCP. Can we discuss the severity of this bug? Obviously some 'oc process' commands may be broken. However, I would think as a workaround someone could grab the latest oc client from Origin. This doesn't seem like a blocker unless a significant number of templates are going to be broken. Also, I'm moving this back to ASSIGNED until we triage it for OCP. This bug should have been moved ON_QA against Origin. I would say this may affect xPaaS customers quite considerably, as any custom maven or java arguments have the form of "-Dfoo=bar" @brenton i think you've summarized it accurately. my main concern is the the use case that hit this bug seems likely to be a common one (jvm args are commonly going to include multple =s). but yes, workarounds do exist. It seems like we may need to perform a rebuild for another high severity bug. Given this is low risk I would say please submit a PR against ose's enterprise-3.3 branch. Already there: https://github.com/openshift/ose/pull/364 (In reply to Brenton Leanhardt from comment #7) > bug. Given this is low risk I would say please submit a PR against ose's > enterprise-3.3 branch. From above discussion, the bug is low risk; H severity is because use case is common. (In reply to Xingxing Xia from comment #3) > Checked on devenv-rhel7_5003 (openshift v1.3.0-rc1+3cd9a1f). Fixed. Multi > '='s work well. Wait for merge into OCP. As said, wait for merge into new puddle. We hope to have an official build for QE testing tomorrow. This has been merged into OCP and is in version v3.3.0.31. This is planned on the GA release. It is in images now and ready for testing. My bad, I didn't notice it was already on the Errata. It's ready for QE now. AFAIK this bug never affected any released version, so it doesn't need doc text? The regression went in on may 2nd: https://github.com/openshift/origin/pull/8049 was that included in 3.2 or 3.2.1? Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1933 |