Bug 1375344

Summary: Modify Azure Runner to use existing EMS
Product: Red Hat CloudForms Management Engine Reporter: John Prause <jprause>
Component: ProvidersAssignee: Daniel Berger <dberger>
Status: CLOSED CURRENTRELEASE QA Contact: Jeff Teehan <jteehan>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 5.6.0CC: jfrey, jhardy, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: provider:azure
Fixed In Version: 5.7.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1376176 (view as bug list) Environment:
Last Closed: 2017-01-11 19:55:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Azure Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1376176    

Description John Prause 2016-09-12 18:45:15 UTC
Currently we are passing individual credentials directly to Runner.new. This is both problematic and inefficient, in the first case because we aren't including proxy information, and in the second case because we already have the connection information we need from the EMS.

This code, which is very similar to the Google provider code, alters the Runner's initialize method to accept an ems object rather than individual credentials. This, in turn, lets us use the :with_provider_connection method which already contains the credentials we need, including the proxy information.

It's also shorter and easier to read. :)

In addition to the specs, this can be validated by firing up a local instance of the app, deliberately triggering an event (such as a power on/off) for a VM, and then look for power events in the UI.

Comment 2 John Prause 2016-09-12 18:46:00 UTC
https://github.com/ManageIQ/manageiq/pull/10710

Comment 4 Jeff Teehan 2016-10-11 19:38:15 UTC
There is no additional test case for refactoring.  Everything is working just fine for the last few builds with the change.  Moving to verified.