Bug 1375434

Summary: [iproute2] ip link show type bond_slave not work
Product: Red Hat Enterprise Linux 7 Reporter: Hangbin Liu <haliu>
Component: iprouteAssignee: Phil Sutter <psutter>
Status: CLOSED ERRATA QA Contact: Jaroslav Aster <jaster>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.3CC: atragler, jaster, mleitner, omoris, sukulkar
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: iproute-3.10.0-78.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 21:32:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Hangbin Liu 2016-09-13 06:31:31 UTC
Description of problem:
after add bond slave, ip link show type bond_slave do not show anything

Version-Release number of selected component (if applicable):
iproute-3.10.0-74.el7

How reproducible:
everytime

Steps to Reproduce:
1. # ip link set p5p1 master bond0
2. # ip link show type bond_slave
3.

Actual results:
show nothing

Expected results:
show slaves

Additional info:
need backport 

commit 03ac85b708168c57ce6ec32dfa5aa850fbf2c4ee
Author: Phil Sutter <phil>
Date:   Thu Jun 30 16:47:02 2016 +0200

    ip-address: constify match_link_kind arg

    Since the function won't ever change the data 'kind' is pointing at, it
    can sanely be made const.

    Fixes: e0513807f6dbb ("ip-address: Support filtering by slave type, too")
    Suggested-by: Stephen Hemminger <shemming>
    Signed-off-by: Phil Sutter <phil>

Comment 1 Phil Sutter 2016-09-20 20:38:24 UTC
Hi Hangbin,

The requested functionality is indeed not available in RHEL7 iproute. The missing patch though is this one:

commit e0513807f6dbbd4631fdbb27f0bd6bbce138e8cd
Author: Phil Sutter <phil>
Date:   Tue Jun 28 15:07:16 2016 +0200

    ip-address: Support filtering by slave type, too
    
    This patch allows to query all interfaces enslaved to a bridge or bond
    using the following syntax:
    
    | ip addr show type bridge_slave
    
    Filtering has to be done in userspace since the kernel does not support
    filtering on IFLA_INFO_SLAVE_KIND.
    
    Functionality introduced in this patch is not fully complete since it
    does not allow to match on type and slave type at the same time, but it
    doesn't prevent implementing a dedicated slave_type match, either.
    
    Signed-off-by: Phil Sutter <phil>

Comment 2 Hangbin Liu 2016-09-22 02:54:28 UTC
(In reply to Phil Sutter from comment #1)
> Hi Hangbin,
> 
> The requested functionality is indeed not available in RHEL7 iproute. The
> missing patch though is this one:
> 
> commit e0513807f6dbbd4631fdbb27f0bd6bbce138e8cd
> Author: Phil Sutter <phil>
> Date:   Tue Jun 28 15:07:16 2016 +0200

ah, no wonder... I thought we already backported this patch. Do we have a internal git repo for iproute2? So I can check what patch we have backported.

Thanks
Hanagbin

Comment 3 Phil Sutter 2016-09-22 10:56:43 UTC
(In reply to Hangbin Liu from comment #2)
> (In reply to Phil Sutter from comment #1)
> > Hi Hangbin,
> > 
> > The requested functionality is indeed not available in RHEL7 iproute. The
> > missing patch though is this one:
> > 
> > commit e0513807f6dbbd4631fdbb27f0bd6bbce138e8cd
> > Author: Phil Sutter <phil>
> > Date:   Tue Jun 28 15:07:16 2016 +0200
> 
> ah, no wonder... I thought we already backported this patch. Do we have a
> internal git repo for iproute2? So I can check what patch we have backported.

Yes, indeed there is: 

http://git.engineering.redhat.com/git/users/psutter/iproute2.git/

Branch rhel7.3 is what you are looking for. I duplicated the kernel git infrastructure as much as possible, so dist-git releases are created from this git in a semi-automatic way.

Cheers, Phil

Comment 4 Hangbin Liu 2016-09-23 07:49:22 UTC
(In reply to Phil Sutter from comment #3)
> Yes, indeed there is: 
> 
> http://git.engineering.redhat.com/git/users/psutter/iproute2.git/
> 
> Branch rhel7.3 is what you are looking for. I duplicated the kernel git
> infrastructure as much as possible, so dist-git releases are created from
> this git in a semi-automatic way.

Cool, thanks

Comment 7 errata-xmlrpc 2017-08-01 21:32:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2171