Bug 1375451

Summary:	Some improvement for 'Clone virtual machine' dialog UI
Product:	Red Hat Enterprise Linux 7	Reporter:	Xiaodai Wang <xiaodwan>
Component:	virt-manager	Assignee:	Pavel Hrdina <phrdina>
Status:	CLOSED WONTFIX	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.3	CC:	jsuchane, juzhou, mxie, mzhan, tzheng
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-19 10:21:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Xiaodai Wang 2016-09-13 07:42:52 UTC

Description of problem:
Some improvement for 'Clone virtual machine' dialog UI

Version-Release number of selected component (if applicable):
virt-manager-1.4.0-2.el7.noarch

How reproducible:
100%

Steps to Reproduce:
1. Open virt-manager.
2. Right click a guest and select 'Clone' to open 'Clone virtual machine' dialog.
3. Press 'Alt' key and check 'Details' button doesn't have a mnemonic charactor.
4. Click 'Details' button at right side of networking mac address and set foucs to New MAC text entry, then Press 'Enter' key.
   The "Change MAC address" dialog doesn't close.
5. Click 'Clone this disk (X GiB)' button, then click Details to open "Change storage path' dialog.
6. Set foucs to New Path text entry and press 'Enter' key.
   The "Change storage path" dialog doesn't close.

Actual results:
as in steps.

Expected results:
1) It's better to add a mnemonic charactor for 'Details' button at right side of networking mac address.
2) It's better to bind 'Enter' key to OK button as with 'Esc' to Cancel button did for "Change MAC address" dialog and "Chagne storage path" dialog.

Additional info:

Comment 1 Pavel Hrdina 2017-01-19 10:21:58 UTC

(In reply to xiaodwan from comment #0)
> Steps to Reproduce:
> 1. Open virt-manager.
> 2. Right click a guest and select 'Clone' to open 'Clone virtual machine'
> dialog.
> 3. Press 'Alt' key and check 'Details' button doesn't have a mnemonic
> charactor.

There could be more than one network interface and each has the "Details..." button so it would be confusing to set a mnemonic character.

> 4. Click 'Details' button at right side of networking mac address and set
> foucs to New MAC text entry, then Press 'Enter' key.
>    The "Change MAC address" dialog doesn't close.
> 5. Click 'Clone this disk (X GiB)' button, then click Details to open
> "Change storage path' dialog.
> 6. Set foucs to New Path text entry and press 'Enter' key.
>    The "Change storage path" dialog doesn't close.

Virt-manager doesn't bind "Enter" to any action and I don't think we should start doing it.  If user want's to use only keyboard they can easily use "Tab" to jump to the "OK" button and then press "Enter".