Bug 1375544

Summary:	[RHV 4.0] Provider snapshot revert should be disabled for a running VM
Product:	Red Hat CloudForms Management Engine	Reporter:	Ilanit Stein <istein>
Component:	Providers	Assignee:	Boriso <bodnopoz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ilanit Stein <istein>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	5.7.0	CC:	cpelland, jfrey, jhardy, obarenbo, oourfali, simaishi
Target Milestone:	GA	Keywords:	TestOnly
Target Release:	5.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	rhev
Fixed In Version:	5.8.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1388152 (view as bug list)		Environment:
Last Closed:	2017-06-12 17:02:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1388152

Description Ilanit Stein 2016-09-13 11:03:19 UTC

Description of problem:

When trying to revert snapshot, for a RHV "UP" VM,
It fails on: [Error] [HTTP response code is 409.]

As such operation is not supported on RHV side,
please disable the revert snapshot option, for RHV "UP" VM.  

Version-Release number of selected component (if applicable):
CFME 5.7.0.0.20160906172503_12f65cb
RHV-4.0.4.2-0.1.el7ev

Additional info:
There might be other VM statuses, where the revert snapshot is not supported in RHV. Disable snapshot revert on CF side, should fit all these VM statuses.

Comment 2 Ilanit Stein 2016-09-13 12:19:35 UTC

On VMware provider,  revert snapshot operation from CF side succeed, for "UP" VM.

Comment 3 CFME Bot 2016-10-05 12:41:09 UTC

https://github.com/ManageIQ/manageiq/pull/11711

Comment 4 CFME Bot 2016-10-17 16:21:58 UTC

New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/c42ce7ad69d17d703051f40a1115fb95fd212007

commit c42ce7ad69d17d703051f40a1115fb95fd212007
Author:     Greg Blomquist <blomquisg>
AuthorDate: Thu Oct 13 08:17:16 2016 -0400
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Thu Oct 13 17:34:33 2016 -0400

    Merge pull request #11711 from borod108/bugs/1375544revert_depend_on_vm_state
    
    Disable revert snapshot when VM is not down
    (cherry picked from commit 2f1b2179eb40564221f011c80116d5b7c1e91b61)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1375544

 .../providers/redhat/infra_manager/vm/operations/snapshot.rb     | 9 +++++++++
 spec/helpers/application_helper/toolbar_builder_spec.rb          | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

Comment 5 CFME Bot 2016-10-17 16:22:49 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/be6b1f4c294dc0ace8179851d7005912444df415

commit be6b1f4c294dc0ace8179851d7005912444df415
Author:     borod108 <bodnopoz>
AuthorDate: Thu Sep 22 16:00:10 2016 +0300
Commit:     borod108 <bodnopoz>
CommitDate: Thu Oct 13 06:05:23 2016 +0300

    Disable revert snapshot when VM is not down
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1375544

 .../providers/redhat/infra_manager/vm/operations/snapshot.rb     | 9 +++++++++
 spec/helpers/application_helper/toolbar_builder_spec.rb          | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

Comment 6 CFME Bot 2016-10-22 04:53:23 UTC

https://github.com/ManageIQ/manageiq/pull/12119

Comment 8 Ilanit Stein 2017-04-04 12:39:48 UTC

Verified on CFME-5.8.0.8/RHV-4.0.7

revert button is disabled, for a down VM snapshots.