Bug 1375570

Summary:	Detach tier commit is allowed when detach tier start goes into failed state
Product:	[Community] GlusterFS	Reporter:	hari gowtham <hgowtham>
Component:	tiering	Assignee:	hari gowtham <hgowtham>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.9	CC:	bugs, dlambrig, hgowtham, kramdoss
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1375565	Environment:
Last Closed:	2016-12-06 06:00:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1374412, 1374584, 1375474, 1375565
Bug Blocks:

Description hari gowtham 2016-09-13 12:43:22 UTC

+++ This bug was initially created as a clone of Bug #1375565 +++

+++ This bug was initially created as a clone of Bug #1375474 +++

+++ This bug was initially created as a clone of Bug #1374584 +++

+++ This bug was initially created as a clone of Bug #1374412 +++

Description of problem:
Detach tier commit operation should not be allowed when detach tier start operation has gone into failed state. There might be files which are not moved from hot to cold tier when a detach tier operation fails. Allowing to commit the operation removes off the hot tier bricks, thereby making those data in hot tier inaccessible.

Version-Release number of selected component (if applicable):
rpm -qa | grep 'gluster'
glusterfs-cli-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
glusterfs-server-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
python-gluster-3.8.3-0.1.git2ea32d9.el7.centos.noarch
glusterfs-client-xlators-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
glusterfs-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
glusterfs-fuse-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
nfs-ganesha-gluster-next.20160813.2f47e8a-1.el7.centos.x86_64
glusterfs-libs-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
glusterfs-api-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
glusterfs-ganesha-3.8.3-0.1.git2ea32d9.el7.centos.x86_64

How reproducible:
Always

Steps to Reproduce:
1. create a tier vol and start detach tier operation
2. kill a brick on hot tier and restore it after a while to fail the detach tier operation
3. Try detach tier commit

Actual results:
detach tier commit is allowed

Expected results:
detach tier commit should not be allowed

Additional info:

--- Additional comment from Worker Ant on 2016-09-09 03:02:31 EDT ---

REVIEW: http://review.gluster.org/15438 (Tier: failing detach commit on detach failure and in-progress) posted (#1) for review on master by hari gowtham (hari.gowtham005)

--- Additional comment from Worker Ant on 2016-09-09 05:24:31 EDT ---

REVIEW: http://review.gluster.org/15438 (Tier: failing detach commit on detach failure and in-progress) posted (#2) for review on master by hari gowtham (hari.gowtham005)

--- Additional comment from Worker Ant on 2016-09-12 09:27:36 EDT ---

COMMIT: http://review.gluster.org/15438 committed in master by Dan Lambright (dlambrig) 
------
commit 1afa0bd91fd23b5131ccc1cceb814a061ac99096
Author: hari gowtham <hgowtham>
Date:   Fri Sep 9 12:26:52 2016 +0530

    Tier: failing detach commit on detach failure and in-progress
    
    PROBLEM: if detach status has failed or if it remains in progress
    we allow detach commit to happen. only detach force should
    be allowed.
    
    FIX: check the detach status for failure or inprogress and disallow
    with the apt error message.
    
    Change-Id: Ib97d540fec67717bb55c18d133187c665cf69ef1
    BUG: 1374584
    Signed-off-by: hari gowtham <hgowtham>
    Reviewed-on: http://review.gluster.org/15438
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: hari gowtham <hari.gowtham005>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Dan Lambright <dlambrig>
    Tested-by: Dan Lambright <dlambrig>

--- Additional comment from Worker Ant on 2016-09-13 08:05:15 EDT ---

REVIEW: http://review.gluster.org/15491 (Tier: failing detach commit on detach failure and in-progress) posted (#1) for review on release-3.7 by hari gowtham (hari.gowtham005)

--- Additional comment from Worker Ant on 2016-09-13 08:29:36 EDT ---

REVIEW: http://review.gluster.org/15492 (Tier: failing detach commit on detach failure and in-progress) posted (#1) for review on release-3.8 by hari gowtham (hari.gowtham005)

Comment 1 Worker Ant 2016-09-13 12:44:06 UTC

REVIEW: http://review.gluster.org/15493 (Tier: failing detach commit on detach failure and in-progress) posted (#1) for review on release-3.9 by hari gowtham (hari.gowtham005)

Comment 2 Worker Ant 2016-09-15 08:04:38 UTC

REVIEW: http://review.gluster.org/15493 (Tier: failing detach commit on detach failure and in-progress) posted (#2) for review on release-3.9 by hari gowtham (hari.gowtham005)

Comment 3 Worker Ant 2016-09-15 20:49:41 UTC

COMMIT: http://review.gluster.org/15493 committed in release-3.9 by Dan Lambright (dlambrig) 
------
commit 0d56f37f66a65915437746d18897200f4bff39b5
Author: hari gowtham <hgowtham>
Date:   Fri Sep 9 12:26:52 2016 +0530

    Tier: failing detach commit on detach failure and in-progress
    
            back-port of: http://review.gluster.org/#/c/15438/
    
    PROBLEM: if detach status has failed or if it remains in progress
    we allow detach commit to happen. only detach force should
    be allowed.
    
    FIX: check the detach status for failure or inprogress and disallow
    with the apt error message.
    
    >Change-Id: Ib97d540fec67717bb55c18d133187c665cf69ef1
    >BUG: 1374584
    >Signed-off-by: hari gowtham <hgowtham>
    >Reviewed-on: http://review.gluster.org/15438
    >Smoke: Gluster Build System <jenkins.org>
    >Tested-by: hari gowtham <hari.gowtham005>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Reviewed-by: Dan Lambright <dlambrig>
    >Tested-by: Dan Lambright <dlambrig>
    Signed-off-by: hari gowtham <hgowtham>
    
    Change-Id: I4f8c3859121ee0827df57348069a243a2502889a
    BUG: 1375570
    Reviewed-on: http://review.gluster.org/15493
    Tested-by: hari gowtham <hari.gowtham005>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Dan Lambright <dlambrig>

Comment 4 Aravinda VK 2016-10-27 05:22:37 UTC

glusterfs-3.9.0rc2 is released[1] and packages are available for different distributions[2] to test.

[1] http://www.gluster.org/pipermail/maintainers/2016-October/001601.html
[2] http://www.gluster.org/pipermail/maintainers/2016-October/001605.html and http://www.gluster.org/pipermail/maintainers/2016-October/001606.html

Comment 5 Aravinda VK 2016-12-06 06:00:56 UTC

Gluster 3.9 GA is released http://blog.gluster.org/2016/11/announcing-gluster-3-9/