| Summary: | DHCP agent still refers to deprecated dhcp_domain | ||
|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Robin Cernin <rcernin> |
| Component: | openstack-neutron | Assignee: | Brian Haley <bhaley> |
| Status: | CLOSED WONTFIX | QA Contact: | Toni Freger <tfreger> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 8.0 (Liberty) | CC: | amuller, bhaley, chrisw, jlibosva, pablo.iranzo, srevivo |
| Target Milestone: | --- | Keywords: | Triaged, ZStream |
| Target Release: | 8.0 (Liberty) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-04-22 14:21:23 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Robin Cernin
2016-09-13 13:22:59 UTC
I contacted folks upstream to speed this along. I see that the backports were abandoned upstream, can you comment on the feasibility of resolving this bug downstream somehow? My first answer is we should set dhcp_domain in dhcp_agent.ini until we have Ocata code as that will fix the problem. Is that possible?
The backports were abandoned since it was touching a configuration option, which can't be removed in a stable release.
I think there's two options:
1. Changing the stable DHCP code to do something like:
domain = self.conf.dns_domain or self.conf.dhcp_domain
So it prefers the new one in neutron.conf over the deprecated one.
2. Add this to neutron/conf/common.py in the dns_domain code:
deprecated_name='dhcp_domain', deprecated_group='dhcp'
#2 would be preferred since it touches just one spot (hopefully).
The only problem is that it needs to merge to master first, then get backported, it can't go directly into stable. So that essentially turns-into commit to master, cherry-pick to stable/*, revert master, but not the stable branches.
So after looking at this further, the only way to get the DHCP agent to honor dns_domain from neutron.conf in anything but Ocata+ is to target a change just at stable/newton, etc. since the agent code itself in those releases ignores the value. The original deprecation code wasn't complete in this regards, and when I removed dhcp_domain in Ocata I created a flag day. We can't go back in time, so I see the best option as just setting both values to be the same until Ocata/OSP11 arrives and we can remove dhcp_domain. The other option is to create a one-off change for OSP10, etc that would allow us to only set dns_domain and have it work. Assaf - I don't know the precedence for that, but it's been frowned-upon at a previous employer :) https://code.engineering.redhat.com/gerrit/#/c/122901/ is an example of a possible downstream-only change to address this issue. Closing as customer case is closed and OSP 8 is going EOL this week. |