Bug 1375671

Summary: Migration options cannot be updated for instance type via webadmin
Product: [oVirt] ovirt-engine Reporter: sefi litmanovich <slitmano>
Component: BLL.VirtAssignee: bugs <bugs>
Status: CLOSED WONTFIX QA Contact: meital avital <mavital>
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.0.4CC: bugs, michal.skrivanek, tjelinek
Target Milestone: ---Flags: tjelinek: ovirt-4.3?
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-24 06:52:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description sefi litmanovich 2016-09-13 16:16:17 UTC
Description of problem:

The migration options 'auto_converged' and 'compressed' exist under the migration attribute of an instance type, but aren't changeable via webadmin
The options should be editable in case no migration policy is chosen or the 'legacy' migration policy is chosen.
In practice, while there is no error issued upon changing the values of these sub attributes, they are actually always kept as 'inherited'.
I get this warning in engine.log:

2016-09-13 19:01:39,021 WARN  [org.ovirt.engine.core.dal.job.ExecutionMessageDirector] (default task-4) [fca0de7] The message key 'UpdateVmTemplate' is missing from 'bundles/ExecutionMessages'

I see also the following ERRORS:

2016-09-13 19:01:46,740 ERROR [org.ovirt.engine.core.sso.utils.SsoUtils] (default task-8) [] OAuthException invalid_scope: The requested scope '[ovirt-ext=revoke:revoke-all]' is invalid, unknown, malformed, or exceeds the scope granted by the resource owner.
2016-09-13 19:01:46,843 ERROR [org.ovirt.engine.core.sso.utils.SsoUtils] (default task-16) [] OAuthException invalid_scope: The requested scope '[ovirt-ext=revoke:revoke-all]' is invalid, unknown, malformed, or exceeds the scope granted by the resource owner.

An even worse case is when I edit the values via api, using PUT call with body such as:

<instance_type>
<migration>
<auto_converge>true</auto_converge>
<compressed>false</compressed>
</migration>
</instance_type>

This change is reflected on API and DB but when editing the instance type in webadmin I can still see theses values set to 'inherited from cluster'.


Version-Release number of selected component (if applicable):
rhevm-4.0.4.2-0.1.el7ev.noarch

How reproducible:
always

Steps to Reproduce:
1. go to configure menu in top right corner of UI.
2. In instance_types tab edit/create an instance type.
3. In edit/create instance_type menu, under host tab choose e.g. 'Enable migration compression' - compress.
4. click ok.


Actual results:
The change is ignored completely and the value is still set to inherited from cluster.

Expected results:
The change is applied.

Additional info:
It should be considered if these options should even exit under instance type, if they're logically not fitting the purpose of the instance type feature I suggest to remove them altogether from both API and webadmin.

Comment 1 Tomas Jelinek 2016-09-15 08:40:47 UTC
they fit the purpose of instance type but considering they work using API the priority is not that high.

Comment 2 Tomas Jelinek 2017-08-14 12:37:27 UTC
Instance types are not highly used, postponing.

Comment 3 Tomas Jelinek 2017-08-24 06:52:22 UTC
I will close this due to capacity. If you will find this as a problem, please feel free to reopen.