Bug 1375862

Summary: It is better to have "Clear filters" under filter box when coming to pod page by clicking pod from overview page
Product: OpenShift Container Platform Reporter: Xingxing Xia <xxia>
Component: Management ConsoleAssignee: Jessica Forrester <jforrest>
Status: CLOSED ERRATA QA Contact: Yadan Pei <yapei>
Severity: low Docs Contact:
Priority: low    
Version: 3.3.0CC: aos-bugs, jokerman, mmccomas, tdawson
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: A DOM element under the label filter component was being removed during certain navigation situations, preventing the 'Clear Filters' link from being added when it needed to be. Consequence: When performing navigation actions the preset a label filter, like jumping to a pre-filtered list of pods from the Overview, the 'Clear Filters' link would not appear, and would no longer appear on any page until the browser was refreshed. Fix: The correct element is now being removed under these navigation situations. Result: The 'Clear Filters' link will always appear when any label filters are active'
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-12 19:06:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Xingxing Xia 2016-09-14 06:55:47 UTC
Description of problem:
Coming to pod page by clicking pod from overview page, it does not show "Clear filters" under the filter box. Even delete the filters, add filters again, it still does not show "Clear filters".
However, if come to pod page by clicking "Applications" --> "Pods" and add filters, "Clear filters" can be shown.

Version-Release number of selected component (if applicable):
v3.3.0.30

How reproducible:
Always

Steps to Reproduce:
1. Login to openshift, create project
2. Create app
$ oc new-app -f https://raw.githubusercontent.com/openshift/origin/master/examples/sample-app/application-template-stibuild.json
3. On web console, in overview page, click the pod circle chart, then it comes to pod page,
1> check "Clear filters" under the filter box
2> delete the filters, add filters, check "Clear filters" again.

Actual results:
3. No "Clear filters" under the filter box in both 1> and 2> .

Expected results:
3. It is better to have "Clear filters"

Additional info:

Comment 1 Xingxing Xia 2016-09-18 09:10:52 UTC
Similar problem is found when clicking the label key or value in one resource object page.
E.g.:
A. Coming to routes page by "Applications" --> "Routes" (in this point, adding filters will show "Clear filters").
B. Then click one specific route "route-edge", it will shows labels: app ruby-helloworld-sample template application-template-stibuild.
C. If now click label key "app", it will turn to routes page with "app" filtered, but not show "Clear filters"; even if delete the filter "app" and add filters again, it will not show "Clear filters".

Comment 2 openshift-github-bot 2016-11-17 17:39:06 UTC
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/f8c677e711ef1313ac4326b25039d2237e463ae7
Bug 1375862 Fix clear filters button getting destroyed when using setLabelSelector

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1375862

Comment 3 Troy Dawson 2017-01-20 23:18:57 UTC
This has been merged into ocp and is in OCP v3.5.0.7 or newer.

Comment 4 Xingxing Xia 2017-01-22 03:07:10 UTC
Checked in OCP v3.5.0.7. Fixed. Now, with steps in comment 0 and 1, "Clear filters" is there.
Note: with step 3 in comment 0, we should click donut of multiple-replicas DC to verify it in 3.5. Click on donut of single-replica DC in 3.5 turns to that pod page directly. This is change vs 3.4

Comment 6 errata-xmlrpc 2017-04-12 19:06:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0884