Bug 1375936

Summary: ntlm-test crash
Product: Red Hat Enterprise Linux 7 Reporter: Jiri Koten <jkoten>
Component: libsoupAssignee: Milan Crha <mcrha>
Status: CLOSED CURRENTRELEASE QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.3CC: danw, tpopela
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: libsoup-2.62.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-07 17:07:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
backtrace none

Description Jiri Koten 2016-09-14 09:37:00 UTC 
Description of problem:
Running the test suite, ntlm-test crashed.

traps: lt-ntlm-test[14285] trap int3 ip:7f7673aa7643 sp:7fff7945af00 error:0

$ ./ntlm-test -d -d               
/ntlm/retry:   /alice
 (S:unauth) (S:sent) (S:unauth) (S:sent) (S:alice)  /bob
 (S:unauth) (S:sent) (S:unauth) (S:sent) (S:alice)OK
/ntlm/builtin/none:  (S:unauth)  /noauth    ->  -> OK
 (S:unauth)  /alice     ->  NTLM_PROMPT BASIC_PROMPT -> Unauthorized
 (S:unauth)  /alice/404 ->  NTLM_PROMPT BASIC_PROMPT -> Unauthorized
 (S:unauth)  /alice     ->  NTLM_PROMPT BASIC_PROMPT -> Unauthorized
 (S:unauth)  /bob       ->  NTLM_PROMPT BASIC_PROMPT -> Unauthorized
 (S:unauth)  /alice     ->  NTLM_PROMPT BASIC_PROMPT -> Unauthorized
 (S:unauth)  /basic     ->  BASIC_PROMPT -> Unauthorized
 (S:unauth)  /either    ->  NTLM_PROMPT BASIC_PROMPT -> Unauthorized
OK
/ntlm/builtin/alice:  (S:sent) (S:alice)  /noauth    ->  REQUEST CHALLENGE NTLM_RESPONSE -> OK
 (S:alice)  /alice     ->  -> OK
 (S:alice)  /alice/404 ->  -> Not Found
 (S:alice)  /alice     ->  -> OK

(ntlm-test:28744): libsoup-WARNING **: SoupMessage 0xed3aa0 stuck in infinite loop?



Version-Release number of selected component (if applicable):
libsoup-2.48.1-6.el7
samba-4.4.4-9.el7

How reproducible:
100%
Comment 1 Jiri Koten 2016-09-14 09:38:05 UTC 
Created attachment 1200780 [details]
backtrace
Comment 2 Dan Winship 2016-09-14 12:05:05 UTC 
Apparently fedora/rhel's version of the patch for bug 1088458 doesn't match the upstream commit. (The upstream version doesn't remove the "conn->state = SOUP_NTLM_FAILED" line.) Fixing that (and pulling in the rest of the upstream patch to get the corresponding change to ntlm-test.c too) fixes ntlm-test, but maybe that breaks the fix for 1088458?
Comment 3 Milan Crha 2019-03-07 17:07:37 UTC 
I just realized that the current 2.62.2 has this fixed, the test doesn't crash and reports:

/ntlm/retry: OK
/ntlm/builtin/none: OK
/ntlm/builtin/alice: OK
/ntlm/builtin/bob: OK
/ntlm/builtin/basic: OK
/ntlm/winbind/none: SKIP
/ntlm/winbind/alice: SKIP
/ntlm/winbind/bob: SKIP
/ntlm/winbind/basic: SKIP
/ntlm/fallback/none: SKIP
/ntlm/fallback/alice: SKIP
/ntlm/fallback/bob: SKIP
/ntlm/fallback/basic: SKIP
/ntlm/ssp/none: OK
/ntlm/ssp/alice: OK
/ntlm/ssp/bob: OK
/ntlm/ssp/basic: OK

when I ran it locally, thus I'm closing this.