Bug 1376126

Summary:	unit file missing Type=notify
Product:	Red Hat Enterprise Linux 7	Reporter:	Qian Cai <qcai>
Component:	flannel-container	Assignee:	Jan Chaloupka <jchaloup>
Status:	CLOSED WONTFIX	QA Contact:	Martin Jenner <mjenner>
Severity:	high	Docs Contact:
Priority:	high
Version:	7.3	CC:	atomic-bugs, imcleod, jchaloup, lfriedma, mjenner
Target Milestone:	rc	Keywords:	Extras
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	flannel-docker-0.5.5-3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-09-29 12:08:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Comment 3 Giuseppe Scrivano 2016-09-15 13:29:32 UTC

there is a pull request upstream:

https://github.com/aveshagarwal/flannel-container/pull/4

that addresses this issue in a different way as we cannot use Type=notify yet.

The PID known to the container process is different than the one on the host.  We will have to figure out a way to support this in future.  CoreOS uses a separate tool (sdnotify-proxy) to convert from the container PID namespace.

Comment 4 Qian Cai 2016-09-15 14:17:24 UTC

In addition, Type=notify is still useful to catch errors from the runc process. For example, the container ID has already existed.

Comment 5 Avesh Agarwal 2016-09-15 16:53:51 UTC

Hi Giuseppe,

I am not sure how is your PR https://github.com/aveshagarwal/flannel-container/pull/4 is related to the issue CAI is talking about here with Type=notify?