Bug 1376339

Summary: [UI] Impossible to create / attach disk after changing Template value
Product: [oVirt] ovirt-engine Reporter: Israel Pinto <ipinto>
Component: BLL.VirtAssignee: Martin Betak <mbetak>
Status: CLOSED CURRENTRELEASE QA Contact: Israel Pinto <ipinto>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.0.2.1CC: bugs, ehildesh, tjelinek
Target Milestone: ovirt-4.1.0-alphaFlags: rule-engine: ovirt-4.1+
rule-engine: planning_ack+
rule-engine: devel_ack+
mavital: testing_ack+
Target Release: 4.1.0.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Incorrect logic that handles availability of adding disks in "New Vm" dialog prevented user to add disk after changing the template in a certain way. Consequence: When creating a new VM, selecting a non-blank template, then selecting back the 'Blank' template, the option to attach disks remained incorrectly greyed out. Fix: Corrected the specific logic related to selection of 'Blank' template and its effect on other UI controls. Result: Now the option to attach disks will be correctly enabled even after mentioned manipulation with the selected template value.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-01 14:48:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot of new vm window
none
engine.log none

Description Israel Pinto 2016-09-15 07:30:48 UTC
Created attachment 1201153 [details]
screenshot of new vm window

Description of problem:
From the UI it impossible to create / attach disk after changing Template value 

Version-Release number of selected component (if applicable):


How reproducible:
100 %

Steps to Reproduce:
1. Open 'New VM' window
2. Choose cluster, Template (not Blank)
3. Set name
4. Go back to Template and set to Blank

Actual results:
The option of create / attach is grayout 

Expected results:
Since we change to Blank we should be able to add disk to VM

Comment 1 Israel Pinto 2016-09-15 08:09:55 UTC
Created attachment 1201157 [details]
engine.log

Comment 2 Israel Pinto 2016-09-15 08:11:12 UTC
Version:
Red Hat Virtualization Manager Version: 4.0.4.2-0.1.el7ev

Comment 3 Martin Betak 2016-11-03 16:58:02 UTC
After a bit of investigation it seems that for templates with disks there is a special handling preventing the mixing of images and template disks. For templates without disks it works. 

@Tomas: can you please confirm this behavior is intended?

Comment 4 Martin Betak 2016-11-24 12:15:44 UTC
Ok it seems there was indeed a bug in the specific flow when switching from a template with disks to the Blank template. Patch posted u/s.

Comment 5 Sandro Bonazzola 2016-12-12 13:55:22 UTC
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.

Comment 6 Israel Pinto 2017-01-11 12:29:12 UTC
Verify with:
Engine:
oVirt Engine Version: 4.2.0-0.0.master.20170104114928.git5490b36.el7.centos
Host:
OS Version:RHEL - 7.3 - 7.el7
Kernel Version:3.10.0 - 514.el7.bug1404060_20.x86_64
KVM Version:2.6.0 - 28.el7_3.3
LIBVIRT Version:libvirt-2.0.0-10.el7_3.2
VDSM Version:vdsm-4.20.0-128.git7001c0a.el7.centos
SPICE Version:0.12.4 - 19.el7

Steps:
1. Open 'New VM' window
2. Choose cluster, Template (not Blank)
3. Set name
4. Go back to Template and set to Blank
5. Add /Attached disk to VM

Results:
PASS

Comment 7 Michal Skrivanek 2017-08-22 07:38:38 UTC
*** Bug 1420752 has been marked as a duplicate of this bug. ***