Bug 1376605

Summary:	Error in changing the RSA Key of an OpenStack Director provider
Product:	Red Hat CloudForms Management Engine	Reporter:	Jerome Marc <jmarc>
Component:	Providers	Assignee:	Sam Lucidi <slucidi>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Omri Hochman <ohochman>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.6.0	CC:	cpelland, dajohnso, gblomqui, jfrey, jhajyahy, jhardy, ldomb, obarenbo, pblaho, rrasouli, slucidi, tzumainn
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	openstack
Fixed In Version:	5.8.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1413207 (view as bug list)		Environment:
Last Closed:	2017-06-12 17:55:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	Openstack	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1413207

Description Jerome Marc 2016-09-15 22:10:15 UTC

Description of problem:
It is impossible to update the RSA key of an OpenStack Provider after it has been created. 

Version-Release number of selected component (if applicable):
5.6.1.2.20160810181333_8ba817b 

How reproducible:
Always

Steps to Reproduce:
1. Edit an OpenStack Director provider
2. Go to 'RSA key pair'
2. Click on 'change stored private key' to upload a new RSA Key
3. Select your file and click Validate

Actual results:
An error message is displayed: 'Credential validation was not successful: undefined method 'verify_credentials' for nil:NilClass'

Expected results:
The Key should be validated 

Additional info:
This prevent from being able to change the RSA key and force the user to delete the provider and create a new one from sratch.

Comment 2 Tzu-Mainn Chen 2016-10-04 14:47:33 UTC

Ronnie, can you test this out and verify?  I remember we tested this feature just a few weeks ago and it seemed to work.

Comment 4 Ronnie Rasouli 2016-11-14 11:39:14 UTC

Mainn, 

I can confirm the scenario described in this BZ reproduce in 5.7.0.10 latest build

Comment 5 ldomb 2016-12-02 22:10:01 UTC

I can confirm the scenario in 5.6.3.3 as well.

Comment 6 Sam Lucidi 2016-12-16 14:35:40 UTC

A pull request to fix this problem is available here: https://github.com/ManageIQ/manageiq/pull/13159

Comment 7 CFME Bot 2017-01-11 14:41:26 UTC

https://github.com/ManageIQ/manageiq/pull/13445

Comment 8 Petr Blaho 2017-01-11 16:50:46 UTC

New PR solving this is the last one - https://github.com/ManageIQ/manageiq/pull/13445

Code from previous one is used in the last one.

Comment 9 CFME Bot 2017-01-13 20:01:17 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/40b17733fe2aec5c23dec647bbfe9d07dd5e4e6b

commit 40b17733fe2aec5c23dec647bbfe9d07dd5e4e6b
Author:     Sam Lucidi <slucidi>
AuthorDate: Tue Dec 13 16:10:23 2016 -0500
Commit:     Petr Blaho <pblaho>
CommitDate: Wed Jan 11 15:37:59 2017 +0100

    Stop nils from appearing in list of hosts to test OSP ssh keys against
    
    Solves
    https://bugzilla.redhat.com/show_bug.cgi?id=1376605

 app/models/manageiq/providers/openstack/infra_manager.rb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comment 11 Ronnie Rasouli 2017-03-09 09:11:28 UTC

verified on 5.8.0.4