Bug 1376645

Summary: recipe reviewed state should not be set automatically if the recipe is still running
Product: [Retired] Beaker Reporter: Dan Callaghan <dcallagh>
Component: web UIAssignee: Dan Callaghan <dcallagh>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: unspecified Docs Contact:
Priority: low    
Version: 23CC: dcallagh, dowang, mjia, rjoost
Target Milestone: 23.3Keywords: EasyFix, Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-07 06:44:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dan Callaghan 2016-09-16 03:28:28 UTC 
Description of problem:


Version-Release number of selected component (if applicable):
23

How reproducible:
easily

Steps to Reproduce:
1. Find a running recipe, open the recipe page
2. Click through to its containing job

Actual results:
The reviewed checkbox for the recipe is checked, because I viewed the recipe page.

Expected results:
It doesn't make sense to consider a recipe as reviewed if it's still running (and therefore producing more results which might require further review). The reviewed checkbox should only be set automatically if the recipe is finished (or in Reserved state, because it also cannot produce any more results at that point).

However there's no reason to prevent people from *manually* marking a recipe as reviewed regardless of its status.
Comment 1 Dan Callaghan 2016-10-04 05:58:01 UTC 
http://gerrit.beaker-project.org/5290
Comment 4 Dan Callaghan 2016-11-07 06:44:26 UTC 
Beaker 23.3 has been released.