Bug 1376660

Summary:	Review Request: golang-github-franela-goblin - Minimal and Beautiful Go testing framework
Product:	[Fedora] Fedora	Reporter:	Matthias Runge <mrunge>
Component:	Package Review	Assignee:	Athos Ribeiro <athoscribeiro>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	athoscribeiro, package-review
Target Milestone:	---	Flags:	athoscribeiro: fedora-review-
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-12 08:00:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1376659

Description Matthias Runge 2016-09-16 06:27:44 UTC

SSpec URL: https://mrunge.fedorapeople.org/reviews/golang-github-franela-goblin/golang-github-franela-goblin.spec

SRPM URL: https://mrunge.fedorapeople.org/reviews/golang-github-franela-goblin/golang-github-franela-goblin-0-0.1.gitefa9910.fc24.src.rpm

Description: Minimal and Beautiful Go testing framework

Fedora Account System Username: mrunge

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15653988

$ rpmlint golang-github-franela-goblin-0-0.1.gitefa9910.fc24.src.rpm golang-github-franela-goblin-devel-0-0.1.gitefa9910.fc24.noarch.rpm golang-github-franela-goblin-unit-test-devel-0-0.1.gitefa9910.fc24.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Athos Ribeiro 2017-05-01 20:11:42 UTC

Hello,

I am taking this one.

- Is there any reason for not running the test suite?

- Upstream does have a version 0.0.1 (see [1]). So maybe you want to package a post release(?)

- If you are packaging a snapshot, - check the new guidelines for the Release: tag. The date the snapshot was taken must be present (this should be updated in gofed). See [2] and [3] for reference.

- The conditionals on lines 52 and 68 could be removed, since they are not used at all.

[1] https://github.com/franela/goblin/tree/0.0.1
[2] https://fedoraproject.org/wiki/Packaging:Versioning
[3] https://fedoraproject.org/wiki/Package_Versioning_Examples

Comment 2 Package Review 2020-07-10 00:55:13 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 3 Athos Ribeiro 2020-07-12 08:00:03 UTC

This is already packaged.

I could not find the review request BZ though.

See https://src.fedoraproject.org/rpms/golang-github-franela-goblin