Bug 1377228

Summary:	Review Request: perl-Test2-Plugin-NoWarnings - Fail if tests warn
Product:	[Fedora] Fedora	Reporter:	Paul Howarth <paul>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-27 00:37:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1377252

Description Paul Howarth 2016-09-19 09:18:03 UTC

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Test2-Plugin-NoWarnings/branches/fedora/perl-Test2-Plugin-NoWarnings.spec

SRPM URL: http://www.city-fan.org/~paul/extras/perl-Test2-Plugin-NoWarnings/perl-Test2-Plugin-NoWarnings-0.02-2.fc26.src.rpm

Description:
Loading this plugin causes your tests to fail if there any warnings while they
run. Each warning generates a new failing test and the warning content is
outputted via diag.

This module uses $SIG{__WARN__}, so if the code you're testing sets this, then
this module will stop working.

Fedora Account System Username: pghmcfc

Note: this package is a dependency of perl-Params-ValidationCompiler, which is a new requirement for the perl-DateTime stack.

Comment 1 Jitka Plesnikova 2016-09-19 10:41:16 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Test2-Plugin-NoWarnings-0.02-2.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Test2::API)
      1 perl(Test2::Event)
      1 perl(Test2::Util::HashBase)
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.


$ rpm -qp --provides perl-Test2-Plugin-NoWarnings-0.02-2.fc26.noarch.rpm | sort | uniq -c
      1 perl(Test2::Event::Warning) = 0.02
      1 perl(Test2::Plugin::NoWarnings) = 0.02
      1 perl-Test2-Plugin-NoWarnings = 0.02-2.fc26
Binary provides are Ok.

$ rpmlint ./perl-Test2-Plugin-NoWarnings*
perl-Test2-Plugin-NoWarnings.noarch: W: spelling-error %description -l en_US diag -> jag, dig, dag
perl-Test2-Plugin-NoWarnings.src: W: spelling-error %description -l en_US diag -> jag, dig, dag
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

BuildRequires are almost ok.
FIX: Please remove 'findutils', it is not used.

Please correct all 'FIX' issues.

Otherwise the package looks good.
Approved.

Comment 2 Gwyn Ciesla 2016-09-19 12:56:12 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test2-Plugin-NoWarnings

Comment 3 Fedora Update System 2016-09-19 13:46:58 UTC

perl-Test2-Plugin-NoWarnings-0.02-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1d82b2619

Comment 4 Fedora Update System 2016-09-20 19:58:40 UTC

perl-Test2-Plugin-NoWarnings-0.02-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1d82b2619

Comment 5 Fedora Update System 2016-09-27 00:37:45 UTC

perl-Test2-Plugin-NoWarnings-0.02-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.